Closed manurohr closed 6 years ago
@manurohr there's an issue with both the log in and register modals. The issue is that any extension modifying the body of the modal will negate the behavior of another extension. It's already a miracle you're seeing both changes, I expect @sijad to have injected the code using javascript and not mithril. In the end what is sent to the server is also important and there either of the extensions might override the payload added by the other.
Until beta 8 I suggest you decide which of these extensions you prefer and de-install the other.
@clarkwinkelmann another conflict extension to add?
@manurohr could you please try my PR #4? I can't test it right now.
@sijad tried your pull request, no php nor flarum logs found. even removed your captcha-extension, had no effect on it.
I'm surprised because I did test this extension and confirmed the two work together without any issue (it's listed as compatible in the discussion)
@manurohr even removed your captcha-extension, had no effect on it.
You mean you still have the issue with @sijad 's extension removed ? Then there's likely another extension in there that's causing the issue. Did you try with all third-party extensions disabled ?
PS: I closed @sijad PR because I'm certain it does not make any difference (explanation in the PR thread)
EDIT: one obvious way to know if an extension is tampering with the terms extension is to look in the network tab while logging in (edit: registering). If the (edit: I meant /login
/register
) endpoint is called it's all good. But if another "register" endpoint is called, it's most likely that an extension replaced the register logic. Flagrow Terms only works if the default route (/register
) is handling the register. So far I've only seen the Reflar User Management doing that, but other extensions could be doing the same.
Okay found the issue while talking to @manurohr on Discord.
It's not related to any other extension. It's an issue with the middleware and Flarum being in a subfolder.
Going to fix this right away :innocent:
Should be fixed in version 0.2.1, let me know if you still have issues :wink:
Great! it worked 👍
I have installed the extension flagrow terms using composer. I have tried to register a new account using german language and activated recaptcha by sijad. I see two tick boxes appearing on the modal and I don't click them. I pass the recaptcha test and click register button. Flarum redirects me to main page and tells me to check confirmation e-mail which I did. After confirming the link in e-mail I was able to create discussions. I do not see any yellow banner telling me to accept tos before using flarum in full capacity.
I expect an error appearing telling me to accept tos first before registering a new account.
Technical Details
Flarum 0.1.0-beta.7PHP 7.1.12 Flagrow Terms: 0.2.0 Browsers: tested in Chrome 66.0, Firefox 60.0.1, Safari 11.1 OS: macOs Sierra, 10.12.6
Logs: one php error found but i guess it's unrelated to this issue:
[28-May-2018 08:34:49 UTC] PHP Notice: Undefined offset: 0 in /Applications/MAMP/htdocs/quickline/vendor/reflar/pretty-mail/src/Mailer.php on line 33
no nginx error, no flarum logs
I have tried
php flarum cache:clear
, also no effect.php debug
is turned on.Flarum Info