search

FriendsOfFlarum / terms

Ask your users to accept TOS and Privacy Policy
https://discuss.flarum.org/d/11714
MIT License
14 stars 10 forks source link

Update en.yml #30

Closed John-S4 closed 3 years ago

John-S4 commented 3 years ago

Simple one word change of text from 'you can now close this modal' to 'you can now close this window'

Most forum users won't know what a modal is, and it just looks strange as a message.

clarkwinkelmann commented 3 years ago

Thanks for the contribution!

Couldn't window also lead to confusion since that could refer to closing the whole browser?

I feel popup might be the better word for people not familiar with what the modal is in Flarum.

I don't remember where exactly that text is shown. Maybe it would be even better to remove the reference to close completely and say something like You can now return to the forum ?

John-S4 commented 3 years ago

The text is shown when someone logs in for the first time after an update to terms, and clicks on the popup message to accept the new terms.

Personally I think that 'window' is fine, because it is a popup window, but I see your point as well.

Agree, that it might be better to skip the modal/window/popup altogether and change the text to something like "Thank you for accepting, you can now return to the forum".

The popup always seems to auto-close in a few seconds anyway, but I'm assuming the original wording is because there are some instances where it might not?

John-S4 commented 3 years ago

Changed as discussed above.