FriendsOfFlarum / terms

Ask your users to accept TOS and Privacy Policy
https://discuss.flarum.org/d/11714
MIT License
14 stars 10 forks source link

I don't have pop-up when click "CLICK HERE TO REVIEW AND ACCEPT THE NEW TERMS" #53

Open rydzacode opened 4 months ago

rydzacode commented 4 months ago

Hello, I have one problem with this extension, when I click "CLICK HERE TO REVIEW AND ACCEPT THE NEW TERMS" I don't see "Terms Update" popup. The forum gets darker, but the window doesn't pop up.

Environment

Screenshot:

ysmla commented 4 months ago

是的,我也是 Flarum 1.8.5 php8.2 MySQL 8.2.0

lwxining commented 4 months ago

so am i。 Safari Firefox chromium ![Uploading 截屏2024-05-31 14.38.36.png…]()

bigreja commented 4 months ago

Same here on safari, macos

javascript errors on console: [Error] TypeError: undefined is not an object (evaluating 'r["@context"].toLowerCase') (função anónima) (forum.superbraga.com:3:186) Código global (forum.superbraga.com:3:363)

[Error] TypeError: undefined is not an object (evaluating 'r().session.user.fofTermsPoliciesState()[t.id()]')

(função anónima) — AcceptPoliciesModal.js:28 filter (função anónima) — AcceptPoliciesModal.js:27 (função anónima) — AcceptPoliciesModal.js:22 (função anónima) — Modal.tsx:164 a — render.js:30 (função anónima) — render.js:155 (função anónima) — render.js:160 c — render.js:66 l — render.js:50 (função anónima) — render.js:134 c — render.js:63 l — render.js:50 f — render.js:277 (função anónima) — render.js:444 p — render.js:415 f — render.js:302 (função anónima) — render.js:444 p — render.js:415 (função anónima) — render.js:488 p — render.js:419 (função anónima) — render.js:488 p — render.js:419 f — render.js:302 (função anónima) — render.js:964 a — mount-redraw.js:14 (função anónima) — mount-redraw.js:25

a (forum.js:2:123358)
(função anónima) (forum.js:2:123409)
Vladimir-Urik commented 4 months ago

Same issue.

TypeError: r().session.user.fofTermsPoliciesState() is undefined
    o AcceptPoliciesModal.js:28
    body AcceptPoliciesModal.js:27
    content AcceptPoliciesModal.js:22
    view Modal.tsx:164
    a render.js:30
    c render.js:155
    c render.js:160
    c render.js:66
    l render.js:50
    c render.js:134
    c render.js:63
    l render.js:50
    f render.js:277
    p render.js:444
    p render.js:415
    f render.js:302
    p render.js:444
    p render.js:415
    p render.js:488
    p render.js:419
    p render.js:488
    p render.js:419
    f render.js:302
    exports render.js:964
    a mount-redraw.js:14
    u mount-redraw.js:25
    u mount-redraw.js:23
    handleEvent render.js:890
    L render.js:910
    k render.js:735
    c render.js:730
    c render.js:122
    c render.js:63
    c render.js:162
    c render.js:66
    l render.js:50
    c render.js:134
    c render.js:63
    l render.js:50
    c render.js:134
    c render.js:63
    l render.js:50
    c render.js:134
    c render.js:63
    l render.js:50
    c render.js:134
    c render.js:63
    c render.js:162
    c render.js:66
    l render.js:50
    c render.js:134
    c render.js:63
    l render.js:50
    c render.js:134
    c render.js:63
    c render.js:162
    c render.js:66
    l render.js:50
    c render.js:103
    c render.js:62
    p render.js:487
    p render.js:419
    f render.js:302
    exports render.js:964
    a mount-redraw.js:14
    m router.js:114
    promise callback*t router.js:126
    k router.js:95
    a render.js:30
    exports render.js:971
    mount mount-redraw.js:45
    y router.js:160
    mount Application.tsx:328
    mount ForumApplication.tsx:114
    boot Application.tsx:299
    <anonymous> (index):118
mount-redraw.js:15:23
cgh1999520 commented 4 months ago

Same issue.

clarkwinkelmann commented 4 months ago

This has been broken in #50 / 1.3.1. UserPoliciesStateModal was updated to load the policies when opened, but AcceptPoliciesModal has not received that code, breaking it.

nxmndr commented 3 months ago

This would need some automated testing.

fushengwushi commented 1 month ago

Same issue.

fushengwushi commented 1 month ago

the issue can be fixed after back to old version composer require fof/terms:"1.3.0"

Lithrun commented 1 week ago

the issue can be fixed after back to old version composer require fof/terms:"1.3.0"

This fixed the issue for me. Thank you!