search

FriendsOfFlarum / transliterator

Transliterate non-ASCII characters in discussion URL
https://discuss.flarum.org/d/18074-friendsofflarum-url-transliterator
MIT License
7 stars 7 forks source link

Need fr.yml #2

Closed HLFH closed 5 years ago

HLFH commented 5 years ago

A reminder for myself and others to translate this extension to French.

luceos commented 5 years ago

This is not a responsibility of the maintainers. And filing reminders on repositories for yourself isn't really helping. Feel free to PR though, we'll gladly review and merge.

HLFH commented 5 years ago

This extension was displaying badly in French as the locale was not provided. As French is an international language, I would have expected to have this extension also in French. If people were spotting quickly on the issues board that it needs French translation, they would have translated. I see a lot of other repos elsewhere where people open issues to say they are keen to contribute to the translations, and in a second stage, they submit PRs. It seems here it is not the case.

luceos commented 5 years ago

It does't make sense would we create issues for all languages that are not represented or have missing translations for all extensions we maintain.

It's also starting to become more of a standard for translations to be contained inside a language pack, instead of inside the extensions. Maintainers of packages don't know all languages to review new or changed translations accurately, whereas translation extensions do.

Thanks for your understanding and commitment to consider contributing.

dsevillamartin commented 5 years ago

Having all the translations in it's own language pack also allows the extension maintainer(s) to not have to focus on updating the old locale, as that job falls into the language pack's maintainer, lifting weight off the extension developers.

This way they can focus on the important features rather than making sure the strings are properly translated.

HLFH commented 5 years ago

@luceos @datitisev Done. https://github.com/FriendsOfFlarum/transliterator/pull/3