search

FriendsOfFlarum / user-directory

The permission based public user directory extension for your Flarum forum.
https://discuss.flarum.org/d/5682
MIT License
22 stars 18 forks source link

Extend IndexPage to avoid replicating nav logic #42

Closed askvortsov1 closed 4 years ago

askvortsov1 commented 4 years ago

As long as we override all the search related and view related methods (which we are doing), this might be cleaner?

clarkwinkelmann commented 4 years ago

I'm not in favor of this. Breaking changes will hit us even harder.

While not exactly the same we had a related issue recently. We extended the avatar upload controller for the watermark image upload in FoF Upload. A change of the constructor signature between beta 12 and beta 13 broke FoF Upload https://github.com/FriendsOfFlarum/upload/issues/214 We would have been better copying the whole code instead of extending the class.

Ideally Flarum should clarify which parts of the javascript/PHP constitutes the public API though. I personally don't think most core components should be listed as extendable outside of modals/alerts and the base component/page.

askvortsov1 commented 4 years ago

Alright, that definitely makes sense!