search

FriendsOfFlarum / user-directory

The permission based public user directory extension for your Flarum forum.
https://discuss.flarum.org/d/5682
MIT License
22 stars 17 forks source link

Add back button #61

Closed rafaucau closed 3 years ago

rafaucau commented 3 years ago

I added a back button (with app.history.push()). I think that sometimes it can be useful. image

davwheat commented 3 years ago

Hey @rafaucau

Thanks for the PR!

Could you remove your changes to the dist JS files, as there are automatically built by the wonderful @flarum-bot when commits are made on master.

rafaucau commented 3 years ago

@davwheat ok, removed By the way, maybe we should add the dist folder to .gitignore?

davwheat commented 3 years ago

If it was ignored, the bot could have issues with committing the compiled files, and people cloning the repo via composer might not get the built JS, so that wouldn't work in this case.

By the way, it looks like you deleted the dist files instead of resetting the changes. Your best bet would be to soft reset to before your initial commit, commit only the src JS files, then force push your changes. Using a git client like GitKraken might be easier.

rafaucau commented 3 years ago

@davwheat It should be okay now