search

FriendsOfFlarum / user-directory

The permission based public user directory extension for your Flarum forum.
https://discuss.flarum.org/d/5682
MIT License
22 stars 16 forks source link

group filter automatically filled with admin or guest group #88

Open Ornanovitch opened 2 years ago

Ornanovitch commented 2 years ago

Bug Report

Current Behavior When using the group filter, it's automatically filled with the admin group or the guest group in addition to the chosen one (but only on frontend, not in the query)

Steps to Reproduce

  1. go to the user directory
  2. use the group filter (select a group)

Expected Behavior The group filter is only filled with the selected group

Screenshots This is what happens when I select "FELINN": Screenshot 2022-03-06 at 13-45-17 Forums de la FELINN

Environment

Flarum core 1.2.0
PHP version: 7.4.25
MySQL version: 5.5.5-10.5.12-MariaDB-0+deb11u1
Loaded extensions: Core, date, libxml, openssl, pcre, zlib, filter, hash, pcntl, Reflection, SPL, session, standard, sodium, mysqlnd, PDO, xml, calendar, ctype, curl, dom, mbstring, FFI, fileinfo, ftp, gd, gettext, gmp, iconv, json, exif, mysqli, pdo_mysql, Phar, posix, readline, shmop, SimpleXML, sockets, sysvmsg, sysvsem, sysvshm, tokenizer, xmlreader, xmlwriter, xsl, zip, Zend OPcache
+-------------------------------+---------+--------+
| Flarum Extensions             |         |        |
+-------------------------------+---------+--------+
| ID                            | Version | Commit |
+-------------------------------+---------+--------+
| flarum-tags                   | v1.2.0  |        |
| flarum-markdown               | v1.2.0  |        |
| the-turk-flamoji              | 1.0.2   |        |
| kyrne-websocket               | 3.3.0   |        |
| fof-user-directory            | 1.2.2   |        |
| fof-user-bio                  | 1.0.2   |        |
| fof-upload                    | 1.1.0   |        |
| fof-terms                     | 1.1.2   |        |
| fof-split                     | 1.0.1   |        |
| fof-reactions                 | 1.0.4   |        |
| fof-merge-discussions         | 1.2.1   |        |
| fof-links                     | 1.0.3   |        |
| fof-linguist                  | 1.0.3   |        |
| fof-formatting                | 1.0.2   |        |
| fof-drafts                    | 1.0.3   |        |
| fof-doorman                   | 1.0.1   |        |
| fof-byobu                     | 1.1.1   |        |
| flarum-subscriptions          | v1.2.0  |        |
| flarum-sticky                 | v1.2.0  |        |
| flarum-statistics             | v1.2.0  |        |
| flarum-nicknames              | v1.2.0  |        |
| flarum-mentions               | v1.2.0  |        |
| flarum-lock                   | v1.2.0  |        |
| flarum-lang-french            | v3.5.0  |        |
| flarum-lang-english           | v1.2.0  |        |
| flarum-emoji                  | v1.2.0  |        |
| clarkwinkelmann-circle-groups | 1.0.0   |        |
| askvortsov-saml               | v2.4.0  |        |
| askvortsov-rich-text          | v2.1.1  |        |
| askvortsov-markdown-tables    | v1.2.1  |        |
| askvortsov-checklist          | v1.3.1  |        |
+-------------------------------+---------+--------+
Base URL: https://talk.felinn.org
Installation path: /var/www/flarum
Queue driver: redis
Mail driver: smtp
Debug mode: off
dsevillamartin commented 10 months ago

I can't reproduce this - is this still an issue?

Ornanovitch commented 10 months ago

Yep, unfortunately, many versions later I still can reproduce this

dsevillamartin commented 10 months ago

Hm, interesting. This is me trying to reproduce it to no avail (on a current dev version since I'm touching up some stuff, but I haven't modified any actual filtering logic)

https://github.com/FriendsOfFlarum/user-directory/assets/6401250/5375a1b4-9552-40d6-adfe-3212a211b468

Ornanovitch commented 10 months ago

Here it is on my side :/

https://github.com/FriendsOfFlarum/user-directory/assets/34077099/4c8d5a05-40b0-4ff5-a396-b28ba66ccf75