search

FriendsOfGalaxy / galaxy-integration-origin

origin integration for galaxy
77 stars 14 forks source link

EA play membership titles shown after membership ran out (add offers cache invalidation) #27

Open fredlllll opened 3 years ago

fredlllll commented 3 years ago

when ea play came out i foolishly took the free trial month without realizing it. the membership then ended and i am now stuck with a bunch of games in my library that i cant play https://i.imgur.com/LSXEFLg.png

these titles all show up in gog galaxy with no hint that they arent really owned by me https://i.imgur.com/AnRdyPD.png syncing games was done way after the membership ran out

i would expect them to not show up in gog galaxy, or at least be marked somehow, but i guess them not showing up would be easier to do?

removing the titles from my origin library does reflect in gog galaxy, so that is a potential solution, but it would be nicer if the plugin just wouldnt sync games that arent playable

FriendsOfGalaxy commented 3 years ago

@fredlllll thanks for the report. Yeah, that is plugin responsibility.

Just to confirm: is it true that plugin returns it as owned games (under Origin tab), not as a origin subscription games (under Subscriptions tab)?

Could you share your logs file as described here? https://github.com/FriendsOfGalaxy/galaxy-integration-origin/wiki/Log-files

fredlllll commented 3 years ago

plugin-origin-7f53219b-4e2b-4591-9f4f-dfc5f4ba9eb0.log

this is the origin plugin log

as i have since removed the titles from my origin library they dont show up on gog anymore, so i cant say if they were under subscriptions or something =/ i only used the my owned games thing

FriendsOfGalaxy commented 3 years ago

Hi, I can see that plugin send proper information to Galaxy that ownership of that subscription is "false".

So that is the Galaxy fault. Please send report via Galaxy menu - Send Report.

FriendsOfGalaxy commented 3 years ago

@fredlllll By the way, I can see a lot of failures for getting sizes of local games. Could you please confirm that for example this file: C:/ProgramData/Origin/LocalContent/CNC and The Covert Operations/map.crc exists?

fredlllll commented 3 years ago

only 5 of the crc files exist. all the other folders only have/had a mfst file in them

i have since reinstalled my windows, so i can only check the backup of my c drive that i made before reinstalling

FriendsOfGalaxy commented 3 years ago

Are those games that have NO crc file installed? How their size and status is shown in Origin? Can you paste one of those mfst file from the game that have NO crc file?

fredlllll commented 3 years ago

the ones without crc have never been installed, the ones with crc have been installed at some point but have since been uninstalled.

here the content of the mfst of mass effect andromeda, which i dont own and there is no crc ?autoresume=0&autostart=0&buildid=&contentversion=1.0.0.10&currentstate=kReadyToStart&ddinitialdownload=0&ddinstallalreadycompleted=0&dipInstallPath=&downloaderversion=9.0.0.0&downloading=0&dynamicdownload=0&eulasaccepted=0&id=Origin.OFR.50.0001646&installdesktopshortcut=0&installerchanged=0&installstartmenushortcut=0&isitoflow=0&islocalsource=0&ispreload=0&isrepair=0&jobID=&locale=&optionalcomponentstoinstall=0&paused=0&previousstate=kInvalid&savedbytes=0&stagedfilecount=0&totalbytes=0

FriendsOfGalaxy commented 3 years ago

Regarding to showing not subscribed games, I have to check again logs but this time with my prepared build package. Please follow these steps:

  1. Make sure Galaxy and Origin applications are turned off
  2. Go to %localappdata%/GOG.com/Galaxy/plugins/installed location
  3. Remove directory with origin plugin
  4. Unpack attached windows.zip to separate folder in above location (for example %localappdata%/GOG.com/Galaxy/plugins/installed/origin_test_plugin)
  5. Run GOG Galaxy and make sure that Origin plugin is connected
  6. Please attach file with origin logs, exactly the same as you did it previously
FriendsOfGalaxy commented 3 years ago

@fredlllll please take a look

fredlllll commented 3 years ago

plugin-origin-7f53219b-4e2b-4591-9f4f-dfc5f4ba9eb0.log

this is the log, i dont know if its the right one though, i had to hook up origin again as galaxy seems to have forgotten all the things i hooked up last time. the log contains two starts cause galaxy updated

FriendsOfGalaxy commented 3 years ago

@fredlllll thanks for logs.

I can see that this time plugin does not report Crysis, Cysis 2 and other games from subscription. Do you see it in Galaxy anyway?

did you disconnected origin plugin by clicking "disconnect" before installing version that I've send to you last time?

Anyway - apparently we do not invalidate offers cache. That is plugin fault.

FriendsOfGalaxy commented 3 years ago

@fredlllll One more question: did you play or at least install all those games that are showing in Origin as expired, or all games from subscription a showing there?

fredlllll commented 3 years ago

nope the games are not visible in galaxy, but i also removed them from my origin library, so i dont know what fixed it.

since i had the problem initially i had to reinstall my computer, so galaxy didnt remember what stuff was connected.

i did play one of the games that showed as expired, shenzhen IO to be precise. but i had it uninstalled at the time of hooking it up to galaxy

FriendsOfGalaxy commented 3 years ago

but i also removed them from my origin library, so i dont know what fixed it.

that is important detail. Did you remove all of subscription games from the origin app? How did you "remove" them? Did you mean "hide" button available under right click?

fredlllll commented 3 years ago

no there was a button "remove all non owned games" or so, cant remember. at least it was meant to remove all games that were added by ea play

FriendsOfGalaxy commented 3 years ago

ok, thank you. Jobs for me: 1) reproduce problem and check how origin API reacts. It is ok to have duplicated 1:1 what is visible in Origin app, although ideally we should filter out games that were never played AND are no longer accesible. 2) we should update cache by removing offers that are no longer in origin API

rodrigovda commented 3 years ago

I am having the same issue where my cancelled EA play membership games still show up my games on my Origin Library but greyed out, so I'm unable to play them, and Origin is showing them as "owned".

I cando whatever you need me to debug it.

I'm also interested in knowing how to delete them from my library (I can't find that magic button "remove all non owned games").

However if I can be of help, I won't delete the games from my library until @FriendsOfGalaxy confirms that he doesn't need me.

@fredlllll if you happen to remember where you found that option, just let me know please.

fredlllll commented 3 years ago

@rodrigovda rightclick one of the game and then remove from library. a popup will ask you if you want to remove only that or all of them

rodrigovda commented 3 years ago

I don't have that option image

fredlllll commented 3 years ago

weird... this is what mine looks like https://i.imgur.com/DX5ITV5.png i also dont have that STEAM logo there, did you try on one that doesnt have the steam logo?

rodrigovda commented 3 years ago

All "EA Play" games have the steam logo (I purchade EA Play" via Steam).

However even if I right click a properly owned game, I don't have that option either. I've tried to change the language to German just in case it was that, but no luck. Weird. Could that be a feature only available in Germany? (I'm from Spain)

fredlllll commented 3 years ago

its only available on that one ea play game that was not removed for some reason when i clicked that the first time. maybe it has to do with you buying eaplay on steam. mine stemmed from getting a trial month of eaplay on origin

FriendsOfGalaxy commented 3 years ago

Hi @rodrigovda please follow those steps as well: https://github.com/FriendsOfGalaxy/galaxy-integration-origin/issues/27#issuecomment-762171695

FriendsOfGalaxy commented 3 years ago

weird... this is what mine looks like i.imgur.com/DX5ITV5.png i also dont have that STEAM logo there, did you try on one that doesnt have the steam logo?

I have this message only when the game itself was removed from EA Play.

rodrigovda commented 3 years ago

Here I attach the log.

I closed the client at 20:02, installed the modified plugin, and re-launched Galaxy at 20:05.

plugin-origin-7f53219b-4e2b-4591-9f4f-dfc5f4ba9eb0.log.txt

rodrigovda commented 3 years ago

Oh, I'm about to post it in the proper GitHub page, but this issue also happens in Steam. I purchased EA play in Steam and now that the suscription is over Galaxy treats the games as owned by both Origin and Steam.