FriendsOfGalaxy / galaxy-integration-uplay

uplay integration with g2.0
MIT License
118 stars 20 forks source link

Game Deluxe edition not recognized! #13

Open chrissix666 opened 4 years ago

chrissix666 commented 4 years ago

Hello! Please dont blame me if it is too exaggerated to raise an issue here. I am testing out GOG Galaxy 2.0 out a lot since the implementation features becomes usable. I am using also almost all available integrations and testing them out and extra buying lot of games to be able to test out.

Uplay integration was so far the most stable running. Also bought the last several months every week a Uplay game. All was fine. On the last week i bought more Uplay games because of the Uplay forward event almost every older game was 80% off. So i also bought the complete Far Cry Collection. But Far Cry 3 was not regocniced in my Gog Galaxy 2.0. I want to try more troubleshooting and just for fun i also bought Far Cry 3 Deluxe Edition (It is an extra game in Uplay libary and not an upgrade) But it got also not visible in GoG Galaxy.

I already raised the issue to Ubisoft support but no response after 2 weekes. They may not feel responsible for external stuff. I have several times disconnected and connected the Uplay integration and also re-installed the addon. It seems to me to exclude that it is a problem on my side.

I am more guessing there exist problems with the ID number handling of the game. Have you maybe an idea what could be an explanation for this? Have over 700 licences on 10 differnt GoG galaxy integrations but this Far Cry 3 issue is currently the greatest mystery.

FriendsOfGalaxy commented 4 years ago

@chrissix666 thanks for detailed report.

So the problem is

So

To know you game ownership license you have to know all of them (or just install-launch pair)

We use space_id, whenever possible because other ids are found from local Uplay files. If we use launch_id then if you have Uplay client uninstalled, then there is no games for you. If we use different id depending on what is available (space_id only if no local client), then we will upload to Galaxy backend many duplicates (if plugin has worked at least once on machine with local Uplay client and without). Things goes worse if you have 2 running instances of Galaxy: one with Uplay installed, second without.

So for now problem is not properly solvable until we have public API that returns game licences.

For now the compromise is to report one game and use install_id to run it. Then Uplay shows prompt to choose exact version: 5309d77b58c243f14c861ab8fbaba6ed

However I don't know how to handle 2 games with the same space_id and different install_id. I haven't seen any so far.