search

FriendsOfGalaxy / galaxy-integration-uplay

uplay integration with g2.0
MIT License
117 stars 20 forks source link

Unable to login to Uplay Account using 2FA #21

Closed humdogm closed 3 years ago

humdogm commented 3 years ago

Describe the bug When logging into my Uplay Account in GOG Galaxy, it does not show a 2FA prompt to ask me for my 6-digit token from my authenticator app. In this state Galaxy only show 2 games when I own many more than that on this Uplay Account, which I know because they show up in the Ubisoft Connect games launcher.

To Reproduce Connect the Uplay plugin for GOG Galaxy Login to your Uplay Account that has 2FA enabled

Observe that you are not given a 2FA prompt Observe that games are missing from the Uplay Bookmark in GOG Galaxy

Expected behavior I expect to be given a 2FA prompt after logging in with my Uplay username and password.

Attached logs plugin-uplay-afb5a69c-b2ee-4d58-b916-f4cd75d4999a.log

humdogm commented 3 years ago

I also observed that in the log file, it often says "Undecided Ownership file path, uplay client might not be installed", which is weird because GOG Galaxy is supposed to be an alternative client.

When I install the Ubisoft Connect Client and login to it, it gives me a 2FA challenge and I login properly. Then I go back to GOG Galaxy and somehow the Uplay Bookmark is able to sync and all my games are there.

I though these plugins were for being standalone replacements of their respective clients? I don't really care to have the Ubisoft Connect client on my computer :/

FriendsOfGalaxy commented 3 years ago

@humdogm unfortunately it is not possible to play ubisoft games without their client installed. We can only make it as much transparent as possible. Games detection is also partially related to Ubisoft client.

For the clarification with 2FA - is it required when you log in the ubisoft club webpage?

humdogm commented 3 years ago

For the clarification with 2FA - is it required when you log in the ubisoft club webpage?

The site does not ask for 2fa when logging into Ubisoft Connect at https://ubisoftconnect.com.

It does ask for 2fa when I navigate to and login to https://account.ubisoft.com.

When logging in to the Ubisoft Connect client, it shows a 2fa prompt.

FriendsOfGalaxy commented 3 years ago

Thanks for details.

Looks like this is a duplication of https://github.com/FriendsOfGalaxy/galaxy-integration-uplay/issues/11

2fa is not an issue here - we do not ask for it as we only authenticate in ubisoftconnect.com

That is current limitation of this plugin - it can properly import data if Ubisoft client is installed. Their API are very restricted and limited, currently no other way.

Plugin won't replace their client entirely without implementing their own client logic that would be tremendous reverse-engineering work.