FriendsOfGalaxy / galaxy-integration-uplay

uplay integration with g2.0
MIT License
118 stars 20 forks source link

Uplay connection keeps disconnecting #33

Open robertkoch13 opened 2 years ago

robertkoch13 commented 2 years ago

I'm having to keep logging in multiple times a day. This started about a day ago, I noticed that Ubisoft Connect needed me to log in after it's last update, but it seems to be working fine after that, but GOG keeps dropping the connection.

image

Michaelrs commented 2 years ago

Same issue here. Mine repeatedly fails reconnecting, possibly because of 2FA. Spammed me those emails at least. Now it disconnected and failed reconnecting so many times my Ubisoft account is temporarily suspended. Cant even login on Ubisoft Connect.

Bansheedragon commented 2 years ago

Having the same issue. I can connect fine, but after a few hours it will disconnect and try to reconnect and I get another 2FA mail. It's really frustrating so I had no choice but to disconnect Ubisoft for the time being.

alexboisot commented 2 years ago

Same issue here. Started a day or two ago.

dsinsti commented 2 years ago

Same here. Started yesterday and keeps repeating. Everytime I launch gog ubi sends a verification code. If anyone can help it would be appreciated. (I don't have the first idea of coding but gog is good except when these things happen)

Bansheedragon commented 2 years ago

Same here. Started yesterday and keeps repeating. Everytime I launch gog ubi sends a verification code. If anyone can help it would be appreciated. (I don't have the first idea of coding but gog is good except when these things happen)

Until it's fixed I recommend you just keep it disconnected. Someone else here got a temporary suspension for too many failed logins as a result.

Michaelrs commented 2 years ago

Same here. Started yesterday and keeps repeating. Everytime I launch gog ubi sends a verification code. If anyone can help it would be appreciated. (I don't have the first idea of coding but gog is good except when these things happen)

Until it's fixed I recommend you just keep it disconnected. Someone else here got a temporary suspension for too many failed logins as a result.

I tried disabled 2FA, and haven't had an issue since. The temporary suspension was less than 12 hours, then I could login again as usual.

So if you feel comfortable disabling 2FA, that seems to be a solution until a fix arrives.

dsinsti commented 2 years ago

Same here. Started yesterday and keeps repeating. Everytime I launch gog ubi sends a verification code. If anyone can help it would be appreciated. (I don't have the first idea of coding but gog is good except when these things happen)

Until it's fixed I recommend you just keep it disconnected. Someone else here got a temporary suspension for too many failed logins as a result.

I tried disabled 2FA, and haven't had an issue since. The temporary suspension was less than 12 hours, then I could login again as usual.

So if you feel comfortable disabling 2FA, that seems to be a solution until a fix arrives.

Thanks for your workaround. I'll wait a little, this issue should be adressed soon.

humdogm commented 2 years ago

Here's my log file if that helps fix this issue: plugin-uplay-afb5a69c-b2ee-4d58-b916-f4cd75d4999a.log

Looks like it sometimes receives a 401 unauthorized from the ubisoft public api, maybe their API changed or they decided to time out people using the public api more often?

Extronic commented 2 years ago

Same error happening to me, multiple times per day and only started happening in the last few days. I've had to just leave it disconnected for now as it'll interrupt the game I'm playing and steal focus, sometimes that means I die in the game or it won't resume and crashes.

JustThat70 commented 2 years ago

I was having this issue as well but now I've been logged in to Ubi through Galaxy for two days straight. Perhaps Ubi solved this on their side?

rknauber commented 2 years ago

It's been 2-3 days for me, was monitoring this from the start and now it seems fine. Assuming something wrong with Ubi's login, etc.

FaithTheSlayer commented 2 years ago

Mine started doing this today.

otro678 commented 2 years ago

Started having this issue today

SylwesterZarebski commented 2 years ago

Confirmed the same, maybe some change on Ubisoft side or temporary error?

mnxn commented 2 years ago

From the logs, it looks like a 403 Forbidden when accessing the Ubisoft API:

2022-01-20 10:37:31,228 - root - DEBUG - Unable to refresh authentication calling auth lost: AccessDenied()
2022-01-20 10:37:31,228 - galaxy.api.jsonrpc - INFO - Sending notification: method=authentication_lost, params=None
2022-01-20 10:37:31,229 - galaxy.api.jsonrpc - DEBUG - Sending 68 bytes of data
2022-01-20 10:37:31,229 - root - ERROR - Encountered exception while parsing club games AccessDenied()
2022-01-20 10:37:31,230 - root - ERROR - Parsing club games failed: AccessDenied()
Traceback (most recent call last):
  File "C:\Users\Max\AppData\Local\GOG.com\Galaxy\plugins\installed\uplay_afb5a69c-b2ee-4d58-b916-f4cd75d4999a\galaxy\http.py", line 119, in handle_exception
    yield
  File "C:\Users\Max\AppData\Local\GOG.com\Galaxy\plugins\installed\uplay_afb5a69c-b2ee-4d58-b916-f4cd75d4999a\backend.py", line 52, in request
    raise error
  File "C:\Users\Max\AppData\Local\GOG.com\Galaxy\plugins\installed\uplay_afb5a69c-b2ee-4d58-b916-f4cd75d4999a\backend.py", line 45, in request
    return await self._session.request(method, url, *args, **kwargs)
  File "C:\Users\Max\AppData\Local\GOG.com\Galaxy\plugins\installed\uplay_afb5a69c-b2ee-4d58-b916-f4cd75d4999a\aiohttp\client.py", line 625, in _request
    resp.raise_for_status()
  File "C:\Users\Max\AppData\Local\GOG.com\Galaxy\plugins\installed\uplay_afb5a69c-b2ee-4d58-b916-f4cd75d4999a\aiohttp\client_reqrep.py", line 1005, in raise_for_status
    headers=self.headers,
aiohttp.client_exceptions.ClientResponseError: 403, message='Forbidden', url=URL('https://public-ubiservices.ubi.com/v1/profiles/me/uplay/graphql')
SylwesterZarebski commented 2 years ago

It is very weird, because list of games is downloaded with statistics etc. Maybe some API changed?

FaithTheSlayer commented 2 years ago

Will this be fixed soon? It seems like these posts have been ignored for a while now since OP

K1LL3RPUNCH commented 2 years ago

yeah, same thing here

Bansheedragon commented 2 years ago

I was having problems with this earlier as well, after w few weeks I tried again and it seemed to be working. Now it keeps disconnecting again, only now I don't get the 2FA request anymore even though I still have 2FA active.

Last time this happened I got a temporary suspension on my ubisoft account due to too many failed logins. I don't want to go through that again or potentially losing my account due to this so until Iknow for certain this issue is fixed, I will just have to keep ubisoft disconnected.

fl4shback commented 2 years ago

Hi! It seems like their app ids changed recently, they are probably removing the last traces of uplay. I managed to track down the new app ids. It seems to work but I'd like someone who has their subscription to test if everything is okay before sending a PR.

Could someone who is subbed to their "gamepass" try to edit following lines of consts.py https://github.com/FriendsOfGalaxy/galaxy-integration-uplay/blob/61d24e4ed0f1b2378252142e5ee2c92cd309612b/src/consts.py#L15-L16

to:

CLUB_APPID = "f35adcb5-1911-440c-b1c9-48fdc1701c68"
CLUB_GENOME_ID = "5b36b900-65d8-47f3-93c8-86bdaa48ab50"

And report if subbed games are correctly added and listed as installed in GOG ?

Thanks

EDIT 22/10/08

Changed IDs to new ones.

SylwesterZarebski commented 2 years ago

After changing guids in %LOCALAPPDATA%\GOG.com\Galaxy\plugins\installed\uplay_afb5a69c-b2ee-4d58-b916-f4cd75d4999a\consts.py no more disconnects. Thanks a lot!

FaithTheSlayer commented 2 years ago

Hi! It seems like their app ids changed recently, they are probably removing the last traces of uplay. I managed to track down the new app ids. It seems to work but I'd like someone who has their subscription to test if everything is okay before sending a PR.

Could someone who is subbed to their "gamepass" try to edit following lines of consts.py to:

https://github.com/FriendsOfGalaxy/galaxy-integration-uplay/blob/61d24e4ed0f1b2378252142e5ee2c92cd309612b/src/consts.py#L15

https://github.com/FriendsOfGalaxy/galaxy-integration-uplay/blob/61d24e4ed0f1b2378252142e5ee2c92cd309612b/src/consts.py#L16

CLUB_APPID = "314d4fef-e568-454a-ae06-43e3bece12a6"
CLUB_GENOME_ID = "85c31714-0941-4876-a18d-2c7e9dce8d40"

And report if subbed games are correctly added and listed as installed in GOG ?

Thanks

THANK YOU!

69NEPHILIM69 commented 2 years ago

Same here

Diven73 commented 2 years ago

Thank you @fl4shback I have confirmed the change of app ids has resolved the "Connection Lost" issue for me. (edit: I do not have a Ubisoft+ subscription.) I did notice in your pull request that you appear to have made a typo there.

You entered the following for line 15: CLUB_APPID = "b314d4fef-e568-454a-ae06-43e3bece12a6"

There is a 'b' at the start that should not be there.

fl4shback commented 2 years ago

Thank you @fl4shback I have confirmed the change of app ids has resolved the "Connection Lost" issue for me. (edit: I do not have a Ubisoft+ subscription.) I did notice in your pull request that you appear to have made a typo there.

You entered the following for line 15: CLUB_APPID = "b314d4fef-e568-454a-ae06-43e3bece12a6"

There is a 'b' at the start that should not be there.

Copy paste gone wrong... Left the first char of the previous key.

Thanks @Diven73 for noticing !

PR Updated

Ramshu commented 2 years ago

Hi! It seems like their app ids changed recently, they are probably removing the last traces of uplay. I managed to track down the new app ids. It seems to work but I'd like someone who has their subscription to test if everything is okay before sending a PR.

Could someone who is subbed to their "gamepass" try to edit following lines of consts.py to:

https://github.com/FriendsOfGalaxy/galaxy-integration-uplay/blob/61d24e4ed0f1b2378252142e5ee2c92cd309612b/src/consts.py#L15

https://github.com/FriendsOfGalaxy/galaxy-integration-uplay/blob/61d24e4ed0f1b2378252142e5ee2c92cd309612b/src/consts.py#L16

CLUB_APPID = "314d4fef-e568-454a-ae06-43e3bece12a6"
CLUB_GENOME_ID = "85c31714-0941-4876-a18d-2c7e9dce8d40"

And report if subbed games are correctly added and listed as installed in GOG ?

Thanks

Works for me thanks 👍

Bansheedragon commented 2 years ago

It does not seem to work for me. It connects just fine, but then a few seconds after connecting it disconnects again every time. I tried restarting GOG Galaxy and I tries reinstalling GOG galaxy, but the problem persists

SylwesterZarebski commented 2 years ago

Did You try to change guids in %LOCALAPPDATA%\GOG.com\Galaxy\plugins\installed\uplay_afb5a69c-b2ee-4d58-b916-f4cd75d4999a\consts.py (guid in uplay_... could be different)?

Bansheedragon commented 2 years ago

Did You try to change guids in %LOCALAPPDATA%\GOG.com\Galaxy\plugins\installed\uplay_afb5a69c-b2ee-4d58-b916-f4cd75d4999a\consts.py (guid in uplay_... could be different)?

Just tried that now and now it will not let me log into ubisoft connect at all. The windows that opens for the login credentials just sits there flashing the ubisoft logo endlessly.

Edit: Forgot to edit both lines, it seems to work now, thanks. I just don't like messing around with stuff like that as I have no idea what I'm doing usually.

dsinsti commented 2 years ago

Seems it's working for me fine. But this issues should be adressed by someone who knows how. In the end is in Ubisoft and GoG best interest for them both that it works.

rknauber commented 2 years ago
CLUB_APPID = "314d4fef-e568-454a-ae06-43e3bece12a6"
CLUB_GENOME_ID = "85c31714-0941-4876-a18d-2c7e9dce8d40"

I changed to these IDs and after launching the app it reconnected and displays all my owned/installed games correctly without me having to manually reconnect.

robertkoch13 commented 2 years ago

I changed the ids in this folder C:\Users\\AppData\Local\GOG.com\Galaxy\plugins\installed\uplay_afb5a69c-b2ee-4d58-b916-f4cd75d4999a

image

I disconnected and reconnected to Uplay, and it's just stuck on the login with the Ubisoft logo flashing

image

fl4shback commented 2 years ago

@robertkoch13 Remove the 'b' letter at the beginning of your CLUB_APPID I did the same copy/paste mistake in my initial PR

robertkoch13 commented 2 years ago

that worked, it connected and synced

TimmermanDave commented 2 years ago

Any idea how to approach this on a mac? I found a corresponding .db file:

/Users/Shared/GOG.com/Galaxy/Storage/plugins/uplay_afb5a69c-b2ee-4d58-b916-f4cd75d4999a-46987963386920830-storage.db

But opening it shows a binary file that I can't update.

fl4shback commented 2 years ago

@TimmermanDave use Finder goto action and paste this: ~/Library/Application Support/GOG.com/Galaxy/plugins/installed

Should take you to where plugins are stored

TimmermanDave commented 2 years ago

Thanks for the pointer, works like a charm! Mac still has the same issue where it can't find the complete list of Ubi games. But it's connecting now!

KayHangman commented 2 years ago

Another confirmation that editing the lines in consts.py worked to immediately correct the issue, all working as it should.

MaximTs commented 2 years ago

Hi! It seems like their app ids changed recently, they are probably removing the last traces of uplay. I managed to track down the new app ids. It seems to work but I'd like someone who has their subscription to test if everything is okay before sending a PR.

Could someone who is subbed to their "gamepass" try to edit following lines of consts.py to:

https://github.com/FriendsOfGalaxy/galaxy-integration-uplay/blob/61d24e4ed0f1b2378252142e5ee2c92cd309612b/src/consts.py#L15

https://github.com/FriendsOfGalaxy/galaxy-integration-uplay/blob/61d24e4ed0f1b2378252142e5ee2c92cd309612b/src/consts.py#L16

CLUB_APPID = "314d4fef-e568-454a-ae06-43e3bece12a6"
CLUB_GENOME_ID = "85c31714-0941-4876-a18d-2c7e9dce8d40"

And report if subbed games are correctly added and listed as installed in GOG ?

Thanks

Just changed %LocalAppData%\GOG.com\Galaxy\plugins\installed\uplay_afb5a69c-b2ee-4d58-b916-f4cd75d4999a\consts.py and all is fine.

Thanks!

Baertram commented 2 years ago

Hi! It seems like their app ids changed recently, they are probably removing the last traces of uplay. I managed to track down the new app ids. It seems to work but I'd like someone who has their subscription to test if everything is okay before sending a PR.

Could someone who is subbed to their "gamepass" try to edit following lines of consts.py to:

https://github.com/FriendsOfGalaxy/galaxy-integration-uplay/blob/61d24e4ed0f1b2378252142e5ee2c92cd309612b/src/consts.py#L15

https://github.com/FriendsOfGalaxy/galaxy-integration-uplay/blob/61d24e4ed0f1b2378252142e5ee2c92cd309612b/src/consts.py#L16

CLUB_APPID = "314d4fef-e568-454a-ae06-43e3bece12a6"
CLUB_GENOME_ID = "85c31714-0941-4876-a18d-2c7e9dce8d40"

And report if subbed games are correctly added and listed as installed in GOG ?

Thanks The connection issues are gone now in the settings. But the owned games were not poperly shown in my games list. You need to disconnect the Ubisoft account connection in the settings and reconnected it, after that it is properly showing the games again and one is able to start them properly.

victorxlxs commented 2 years ago

CLUB_APPID = "314d4fef-e568-454a-ae06-43e3bece12a6" CLUB_GENOME_ID = "85c31714-0941-4876-a18d-2c7e9dce8d40"

This fix works like a charm.

Great job! thousands of thanks ; )

BradB111 commented 2 years ago

CLUB_APPID = "314d4fef-e568-454a-ae06-43e3bece12a6" CLUB_GENOME_ID = "85c31714-0941-4876-a18d-2c7e9dce8d40"

Also working for me within consts.py

Thank you!

Horatius80 commented 2 years ago

After changing API IDs everything works perfectly. Thanx

cesarmolina commented 2 years ago

can confirm changing CLUB IDs worked. no more disconnection issues

K1LL3RPUNCH commented 2 years ago

update when

eebssk1 commented 2 years ago

Now it can't keep my login information,I need to login manually on every reboot

anujdatar commented 2 years ago

Hi! It seems like their app ids changed recently, they are probably removing the last traces of uplay. I managed to track down the new app ids. It seems to work but I'd like someone who has their subscription to test if everything is okay before sending a PR.

Could someone who is subbed to their "gamepass" try to edit following lines of consts.py to:

https://github.com/FriendsOfGalaxy/galaxy-integration-uplay/blob/61d24e4ed0f1b2378252142e5ee2c92cd309612b/src/consts.py#L15

https://github.com/FriendsOfGalaxy/galaxy-integration-uplay/blob/61d24e4ed0f1b2378252142e5ee2c92cd309612b/src/consts.py#L16

CLUB_APPID = "314d4fef-e568-454a-ae06-43e3bece12a6"
CLUB_GENOME_ID = "85c31714-0941-4876-a18d-2c7e9dce8d40"

And report if subbed games are correctly added and listed as installed in GOG ?

Thanks

Worked for me. Don't have gamepass, but my purchased games show up, and I don't disconnects anymore.

Thanks

sunrah27 commented 2 years ago

Hi,

I can confirm this change is working. I have an active Xbox Game Pass and am using GOG Galaxy.

jjwfisher commented 2 years ago

Hi! It seems like their app ids changed recently, they are probably removing the last traces of uplay. I managed to track down the new app ids. It seems to work but I'd like someone who has their subscription to test if everything is okay before sending a PR. Could someone who is subbed to their "gamepass" try to edit following lines of consts.py to: https://github.com/FriendsOfGalaxy/galaxy-integration-uplay/blob/61d24e4ed0f1b2378252142e5ee2c92cd309612b/src/consts.py#L15

https://github.com/FriendsOfGalaxy/galaxy-integration-uplay/blob/61d24e4ed0f1b2378252142e5ee2c92cd309612b/src/consts.py#L16

CLUB_APPID = "314d4fef-e568-454a-ae06-43e3bece12a6"
CLUB_GENOME_ID = "85c31714-0941-4876-a18d-2c7e9dce8d40"

And report if subbed games are correctly added and listed as installed in GOG ? Thanks

Worked for me. Don't have gamepass, but my purchased games show up, and I don't disconnects anymore.

Thanks

Same as the above, many thanks for the fix :)

Amoeba00 commented 2 years ago

Just recently upgraded to Win11 but all my profile settings were on a different drive. Never could figure out why uplay wouldn't work any more, but GOG support pointed me here and changing those values in the consts.py file did the trick. Thanks much!