search

FriendsOfPHP / Goutte

Goutte, a simple PHP Web Scraper
MIT License
9.26k stars 1.01k forks source link

Allow http exceptions #356

Closed janvernieuwe closed 6 years ago

janvernieuwe commented 6 years ago

Fixes #355

Let users decide if they want http exceptions with the http_errors guzzle option.

janvernieuwe commented 6 years ago

@fabpot would you consider this PR?

Another option would be to set it trough the goutte client itself, but this just seemed the most clean way to me, but I can understand choosing for setting it trough the client for BC reasons.

stof commented 6 years ago

-1 for that, as that breaks the BrowserKit expectation which ask to return a response.

janvernieuwe commented 6 years ago

Thanks for the answer.