FriendsOfPHP / Goutte

Goutte, a simple PHP Web Scraper
MIT License
9.26k stars 1.01k forks source link

Remove PHP5 support #387

Closed adrienlucas closed 4 years ago

adrienlucas commented 5 years ago

As requested there : https://github.com/FriendsOfPHP/Goutte/pull/382#discussion_r298563682

But i'm not sure that we actually want to drop the support for Symfony 2.8... Should we wait for EOL ? Or is there another way ?

adrienlucas commented 5 years ago

Travis is failing on the nightly build because of the composer constraint ^7.1.3 not allowing PHP8. Should I either remove the nightly build or just change the constraint to ^7.1.3 || ^8.0 ?

dunglas commented 5 years ago

I would drop nightly from the matrix.

adrienlucas commented 5 years ago

I would drop nightly from the matrix.

Done.

fabpot commented 4 years ago

Thank you @adrienlucas.