search

FriendsOfPHP / Goutte

Goutte, a simple PHP Web Scraper
MIT License
9.26k stars 1.01k forks source link

Raise Guzzle version at least to 6.3 #393

Closed DonCallisto closed 4 years ago

DonCallisto commented 4 years ago

I recently found this https://github.com/guzzle/guzzle/issues/1973 that was merged in Guzzle 6.3 so i think we should bump Guzzle version and release a 3.3 version of Goutte.

Any thoughts?

If this is fine, I'm willing to do the necessary work.

fabpot commented 4 years ago

Version 6.3 are already supported, there is nothing to do.

DonCallisto commented 4 years ago

But version 6.2 got the issue I’ve linked so if I try to test with low deps I encounter the error that’s shown in linked issue. I’m not stating that you should raise the minimum version because of low deps but because 6.2 has that error that, virtually, makes this library unusable.

DonCallisto commented 4 years ago

I've found that with conflict I can overcome the issue. Still doubtful about keeping Guzzle 6.2 version supported by this library.