Allow php8 on v3 - Githubissues

FriendsOfPHP / Goutte

Goutte, a simple PHP Web Scraper

MIT License

9.26k stars 1.01k forks source link

Allow php8 on v3 #432

Closed alexpott closed 3 years ago

alexpott commented 3 years ago

Can commit f117817 be cherry-picked on top of 3.3.0 and a new release made. It would really help Drupal to have a v3 of Goutte that is PHP 8 compatible. We've got a plan to move off Goutte v3 but it would really help if we could do that in Drupal 10 and not mid Drupal 9 cycle.

alexpott commented 3 years ago

Yay the nightly PHP build (PHP 8.0) is green - https://github.com/FriendsOfPHP/Goutte/pull/432/checks?check_run_id=1335754069

alexpott commented 3 years ago

Note this PR does not need to be merged. Cherry-picking the existing commit f117817 on top of v3.3.0 is enough.

fabpot commented 3 years ago

v3.3.1 has just been released to "support" PHP 8.