search

FriendsOfPHP / pickle

PHP Extension installer
Other
1.65k stars 88 forks source link

PHP 7.0+ Compatibility #159

Closed SerafimArts closed 4 years ago

SerafimArts commented 5 years ago

Pickle version 0.4.0 (last stable: https://github.com/FriendsOfPHP/pickle/releases)

This is a repetition of this https://github.com/FriendsOfPHP/pickle/issues/129 error that has not yet been repaired.

Error:

PHP Fatal error:  Cannot use 'String' as class name as it is reserved in phar:///home/travis/build/railt/railt/pickle.phar/vendor/justinrainbow/json-schema/src/JsonSchema/Constraints/String.php on line 18

Is it planned to support pickle? Because I can't use PECL because it is not compatible with php 8.0-dev :D

pierrejoye commented 5 years ago

We should report this bug to Json-Shema :)

On Sat, Mar 2, 2019, 10:57 AM Kirill Nesmeyanov notifications@github.com wrote:

Pickle version 0.4.0 (last stable: https://github.com/FriendsOfPHP/pickle/releases)

Error:

PHP Fatal error: Cannot use 'String' as class name as it is reserved in phar:///home/travis/build/railt/railt/pickle.phar/vendor/justinrainbow/json-schema/src/JsonSchema/Constraints/String.php on line 18

Is it planned to support pickle? Because I can't use PECL because it is not compatible with php 8.0-dev :D

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/FriendsOfPHP/pickle/issues/159, or mute the thread https://github.com/notifications/unsubscribe-auth/AARPKDx9aZkaPbNpivo7QGox0pt7fTeOks5vSfa3gaJpZM4baKDK .

staabm commented 5 years ago

I guess we need to update json schema. Pickle depends on ^1.5 but the latest version is 5.x

https://github.com/justinrainbow/json-schema/releases

I guess somewhere in between php7 compat was added

SerafimArts commented 5 years ago

We should report this bug to Json-Shema :)

Nope =) As @staabm correctly said, you just need to update it

pierrejoye commented 5 years ago

even better :))

On Sat, Mar 2, 2019, 11:05 PM Kirill Nesmeyanov notifications@github.com wrote:

We should report this bug to Json-Shema :)

Nope =) As @staabm https://github.com/staabm correctly said, you just need to update it

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/FriendsOfPHP/pickle/issues/159#issuecomment-468933623, or mute the thread https://github.com/notifications/unsubscribe-auth/AARPKNaVigIIulSJXprhnBk2bnbiIzQOks5vSqE5gaJpZM4baKDK .

pierrejoye commented 4 years ago

This is fixed, in Atoum too :)