There seems to have been a refactor to avoid the deprecated method componentWillReceiveProps. This decision lead to this.props being used within calcTheme and its function calls.
As a result, methods use outdated props including theme in my use case. Once the update is completed, the component never recalculates to use the latest props.
Ex. Developer updates the theme of a global component when changing views. The theme never updates because when theme !== nextProps.theme, all methods destructure from this.props. Thus resulting in theme(old) being used.
This fix aims to provide the most up to date props when calculating theme #78
justyn-clark
commented
5 years ago
There seems to have been a refactor to avoid the deprecated method
componentWillReceiveProps. This decision lead tothis.propsbeing used withincalcThemeand its function calls.As a result, methods use outdated props including
themein my use case. Once the update is completed, the component never recalculates to use the latest props.Ex. Developer updates the theme of a global component when changing views. The theme never updates because when
theme !== nextProps.theme, all methods destructure fromthis.props. Thus resulting intheme(old) being used.This fix aims to provide the most up to date props when calculating theme #78
Fixes: #78