search

FriendsOfShopware / FroshPlatformHtmlMinify

This plugin allows you to minify your HTML output.
MIT License
10 stars 3 forks source link

Plugin destroys JS #4

Closed faesslich closed 3 years ago

faesslich commented 3 years ago

Using the plugin is causing multiple JS errors. Some of the code has been written in the javascript file structure and some has been written directly inside of the base_body_script block of the template.

For whatever reason this isn't caused by one code snippet alone. If I simply remove the causing snippet, just another script from any other plugin crashes.

As you can see, my shop instance doesn't throw notices, warning or errors at all without the plugin activated, but throws a few errors with it been activated. And like I said, if I remove the causing snippets, I get other errors.

Normally: Screenshot 2021-04-21 082209

With plugin: Screenshot 2021-04-21 082251

tinect commented 3 years ago

Could you please send me the original html-source of the related site to reproduce the error? Gladly by PM in slack: https://slack.shopware.com/

tinect commented 3 years ago

Hey @faesslich I'd like to inspect your problem. Therefore, I need some feedback :-)

tinect commented 3 years ago

Sadly, it looks like there is no need...