search

FriendsOfShopware / FroshPlatformMailArchive

This plugin allows you to archive your mails.
MIT License
17 stars 13 forks source link

Implementation of transportState filter #84

Closed flkasper closed 2 months ago

flkasper commented 3 months ago

Resolves #83

tinect commented 3 months ago

Hey @flkasper thank you for the PR. When using the new filter, I miss the relevant info in the grid. What do you think of adding the transportState also in column - not just showing the red icon on createAt column?

flkasper commented 2 months ago

@tinect Column added. I have also moved the failed icon to the new column, as they belong together.

tinect commented 2 months ago

Great, thank you! I've added a few adjustments. Would you please check the PR on your fork? https://github.com/flkasper/FroshPlatformMailArchive/pull/1

flkasper commented 2 months ago

@tinect I had also considered including your adjustments, but then left them out because they are only indirectly related to the new feature and would usually be done in a second PR.

shyim commented 2 months ago

@tinect

image

you can push into prs FYI 😂

tinect commented 2 months ago

@tinect image

you can push into prs FYI 😂

@shyim For unknown reasons I had no permissions to do so :-(

tinect commented 2 months ago

@flkasper thank you. I will do a few testings, create an release vor v2 and migrate it to v3.

thank you very much!