search

FriendsOfShopware / FroshPlatformMailArchive

This plugin allows you to archive your mails.
MIT License
17 stars 13 forks source link

fix: Attachments show up correctly again now #92

Open schneider-felix opened 1 month ago

schneider-felix commented 1 month ago

This PR fixes #88

Because of the way Shopware handles attachments, the attachments are not resolved before the MailTransport has run. That's why we need to save attachments in the Subscriber.

While I was at it I also improved the UI of attachments.

image
flkasper commented 1 month ago

@schneider-felix It would be desirable if the change were also integrated in 2.x. Shopware 6.5 is still used quite frequently.

schneider-felix commented 1 month ago

@schneider-felix It would be desirable if the change were also integrated in 2.x. Shopware 6.5 is still used quite frequently.

@flkasper Sure, I will backport this to the 2.x branch, after @tinect or @shyim had the chance to review this change.

schneider-felix commented 1 month ago

This might also solve #93

The BCC recipient set in the MailSender should be considered with this change.

https://github.com/shopware/shopware/blob/trunk/src/Core/Content/Mail/Service/MailSender.php#L49