search

FriendsOfShopware / FroshShareBasket

This plugin allows your customers to save the current basket and share it via link.
MIT License
8 stars 5 forks source link

Inject only required services #2

Closed dneustadt closed 5 years ago

dneustadt commented 5 years ago

https://github.com/FriendsOfShopware/FroshShareBasket/blob/238c7bfca6f1a10f9e42eb9d32452b31a21dc8d6/Subscriber/Checkout.php#L45

You seem to only require the router service here. Why not just inject it directly instead of the service container? :)

https://github.com/FriendsOfShopware/FroshShareBasket/blob/238c7bfca6f1a10f9e42eb9d32452b31a21dc8d6/Subscriber/CronJob.php#L50

Same goes for this subscriber where you only require dbal_connection