FriendsOfShopware / FroshTools

A collection of useful tools for Shopware 6
MIT License
61 stars 27 forks source link

Other than MySQL is not an error #224

Closed thesec closed 10 months ago

thesec commented 12 months ago

PHP Version

any

Shopware Version

any

Actual behaviour

Performance recommendations render other than a MySQL DB as an error.

It is clearly not such and other, like MariaDB, have been recommended not long ago.

Expected behaviour

Render other than MySQL as a fyi in performance recommendations.

Steps to Reproduce?

Open Tools / System Status on any instance with other than MySQL DB.

shyim commented 10 months ago

I changed it to a warning.

jr-timme commented 10 months ago

If MariaDB is used in place of MySQL I think it also should just return a warning, as MariaDB is also officially supported.

diff --git a/src/Components/Health/Checker/PerformanceChecker/MySQL8Checker.php b/src/Components/Health/Checker/PerformanceChecker/MySQL8Checker.php
index 02b8fad..3dfef20 100644
--- a/src/Components/Health/Checker/PerformanceChecker/MySQL8Checker.php
+++ b/src/Components/Health/Checker/PerformanceChecker/MySQL8Checker.php
@@ -24,7 +24,7 @@ class MySQL8Checker implements PerformanceCheckerInterface, CheckerInterface

         if (isset($extractedVersion['mariadb'])) {
             $collection->add(
-                SettingsResult::error('mysql8', 'MySQL', $version, 'MySQL 8.0', 'https://developer.shopware.com/docs/guides/hosting/performance/performance-tweaks#mysql-instead-of-mariadb')
+                SettingsResult::warning('mysql8', 'MySQL', $version, 'MySQL 8.0', 'https://developer.shopware.com/docs/guides/hosting/performance/performance-tweaks#mysql-instead-of-mariadb')
             );

             return;