shyim
commented
2 years ago Why do you need such images?
Open mtstst opened 2 years ago
shyim
commented
2 years ago Why do you need such images?
mtstst
commented
2 years ago Hi Shyim,
we use your froshWebP in a customer project.
Here, this image is used as a template for marketing print media of a rollup display. That is the reason for these huge dimensions. It is provided as download for B2B customer. In fact, this image must not be converted into webp.
The plugin used for media downloads is based on the media manager, therefore the image must be included in the media manager.
As your plugin has no function to ignore certain images (i.e. by a custom attribute for the media object) or folder, it should skip the not convertable image to process all other.
At this time we have to delete the image in the media manager, generate all webp images and upload the image again. If you want to force regeneration, you will have to do it again.
Best regards,
Thomas Stiebner Geschäftsführer
MTS Internet GmbH Hinter dem Turme 7 D-38114 Braunschweig
Tel: 0531 - 25252-22 Fax: 0531 - 25252-99 eMail: @.> @. Bitte richten Sie alle Anfragen und Meldungen zu Supportfällen an die folgenden E-Mail Adressen: Systemhaus Anfragen / Störungen: @.> @. Internet Anfragen / Störungen: @.> @.
Supportinformationen an personenbezogene E-Mail Adressen werden aus datenschutzrechtlichen Gründen bei Abwesenheit des Ansprechpartners – auch ohne Rückmeldung – nicht bearbeitet!
Handelsreg.Nr. HR B 4658 | Amtsgericht Braunschweig | Sitz der Gesellschaft: Braunschweig | Geschäftsführer: Thomas Stiebner
E-Mail Disclaimer Diese Nachricht kann vertrauliche Informationen enthalten. Sollten Sie nicht der vorgesehene Empfänger sein, so bitten wir Sie, den Absender unverzüglich zu informieren und die E-Mail zu löschen. Jeder unbefugte Zugriff oder jede unbefugte Weiterleitung, die Fertigung einer Kopie, die Veröffentlichung oder sonstige in diesem Zusammenhang stehende Handlung ist untersagt. Da wir nicht die Echtheit oder Vollständigkeit der in dieser Nachricht enthaltenen Informationen garantieren können, schließen wir die rechtliche Verbindlichkeit der vorstehenden Erklärungen und Äußerungen aus.
Von: Shyim @.> Gesendet: Donnerstag, 23. Juni 2022 21:12 An: FriendsOfShopware/FroshWebP @.> Cc: Stiebner, Thomas @.>; Author @.> Betreff: Re: [FriendsOfShopware/FroshWebP] Image dimensions greater than 16383 lead to interruption of generate command (Issue #119)
Why do you need such images? — Reply to this email directly, view it on GitHub https://github.com/FriendsOfShopware/FroshWebP/issues/119#issuecomment-1164773322 , or unsubscribe https://github.com/notifications/unsubscribe-auth/AD26GVVEOPKONRINUE6MOATVQSZGRANCNFSM5ZTPIJ7A . You are receiving this because you authored the thread. http://cdn.mailscanner.info/1x1spacer.gif Message ID: @. @.> > [ { @.": "http://schema.org", @.": "EmailMessage", "potentialAction": { @.": "ViewAction", "target": "https://github.com/FriendsOfShopware/FroshWebP/issues/119#issuecomment-1164773322", "url": "https://github.com/FriendsOfShopware/FroshWebP/issues/119#issuecomment-1164773322", "name": "View Issue" }, "description": "View this Issue on GitHub", "publisher": { @.": "Organization", "name": "GitHub", "url": "https://github.com" } } ]
PHP Version
7.4
Shopware Version
5.7.11
Actual behaviour
When running the frosh:webp:generate command, processing stops on very large images with an error in the webp library and the remaining images are not processed. A message appears that the maximum dimensions of an image must not exceed 16383 pixels.
It would be desirable to log the affected image, skip it and continue with the remaining images.
In the case of invalid sRGB profiles of an image, a corresponding note is issued, but unfortunately no image name is given, so that an assignment of the faulty image is not possible for a normal user.
Expected behaviour
not interrupting the command, skip the large image, log the error
Steps to Reproduce?
upload an image with dimensions > 16383 to media manager and after that upload a few smaller images, activate froshWebp, use frosh:webp:generate command. The images uploaded after the large one have no webp copy.