FriendsOfShopware / FroshWebP

WebP Support for Shopware

MIT License

35 stars 25 forks source link

Force flag causes Fatal Error #60

Closed DanMan closed 4 years ago

DanMan commented 4 years ago

Prerequisites

Actual behaviour

PHP Fatal error:  Uncaught TypeError: Return value of FroshWebP\Components\ImageStack\Arguments::isForce() must be of the type boolean, null returned in custom/plugins/FroshWebP/Components/ImageStack/Arguments.php:90

Expected behaviour

No errors and re-creation of the WebP images.

Environment

Shopware 5.6.3 Plugin 1.1.0 and Google Binary only PHP 7.2.27

Steps to reproduce

Invoke ./bin/console frosh:webp:generate -f from the CLI

Checklist

[x] I have checked all issues and haven't found a similar report.
[x] I am using the latest stable version of this plugin.

DanMan commented 4 years ago

I applied a similar hotfix before I posted this bug report. It didn't lead to re-generation of the images though, which I hinted at under "Expected behaviour". Has anyone actually tested that? If it's exposed on the console, but it doesn't do anything…