FriendsOfShopware / packages

Shopware Composer Repository
https://packages.friendsofshopware.com
MIT License
19 stars 7 forks source link

HbdevRechtstexte cannot be installed #25

Closed stefanpoensgen closed 4 years ago

stefanpoensgen commented 4 years ago

The package gets added in the correct way to the composer.json and there are no errors during composer install. But the files never appear in Plugins/Community/Backend.

https://packages.friendsofshopware.com/packages/store.shopware.com/hbdevrechtstexte/

shyim commented 4 years ago

Are you using the default composer project template? Maybe thats the issue https://github.com/shopware/composer-project/pull/47/files

stefanpoensgen commented 4 years ago

Yes, I'm using the standard composer package, but I've already fixed this part. For example, SwagImportExport is installed correctly.

composer.json

....
"require": {
        "php": "^7.2",
        "composer/installers": "^1.0",
        "cweagans/composer-patches": "^1.6",
        "frosh/mail-catcher": "^1.2",
        "ocramius/package-versions": "1.2.0",
        "shopware/shopware": "^5.6",
        "store.shopware.com/cbaxconnectorebayarticle": "^2.7",
        "store.shopware.com/froshsharebasket": "^1.1",
        "store.shopware.com/froshwebp": "^1.1",
        "store.shopware.com/hbdevrechtstexte": "^5.5",
        "store.shopware.com/swagimportexport": "^2.10",
        "store.shopware.com/swagpaymentpaypalunified": "^2.6",
        "vlucas/phpdotenv": "^3.1"
    },
...

composer install log

 ...
 - Installing store.shopware.com/froshwebp (1.1.0): Downloading (100%)         
  - Installing store.shopware.com/cbaxconnectorebayarticle (2.7.5): Downloading (100%)         
  - Installing store.shopware.com/froshsharebasket (1.1.5): Downloading (100%)         
  - Installing store.shopware.com/hbdevrechtstexte (5.5.14): Downloading (100%)         
  - Installing store.shopware.com/swagimportexport (2.10.3): Downloading (100%)         
  - Installing store.shopware.com/swagpaymentpaypalunified (2.6.4): Downloading (100%)         
  - Installing phpoption/phpoption (1.7.2): Loading from cache
  - Installing vlucas/phpdotenv (v3.6.0): Loading from cache
symfony/service-contracts suggests installing symfony/service-implementation
symfony/console suggests installing symfony/lock
...

before frosh packages i used https://github.com/shyim/store-plugin-installer this works but frosh packages is way more comfortable

htuscher commented 4 years ago

Is that plugin built with the 5.2 plugin system or the legacy system?

We also had issues installing legacy plugins.

    "extra": {
        "installer-paths": {
            "Plugins/Local/Backend/{$name}/": [
                "type:shopware-backend-plugin"
            ],
            "Plugins/Local/Core/{$name}/": [
                "type:shopware-core-plugin"
            ],
            "Plugins/Local/Frontend/{$name}/": [
                "type:shopware-frontend-plugin"
            ]
        }
    },

VS:

    "extra": {
        "installer-paths": {
            "Plugins/Community/Backend/": [
                "type:shopware-backend-plugin"
            ],
            "Plugins/Community/Core/": [
                "type:shopware-core-plugin"
            ],
            "Plugins/Community/Frontend/": [
                "type:shopware-frontend-plugin"
            ]
        }
    },

They ended up having nested folders e.g. Plugins/Local/Backend/SomePlugin/SomePlugin/

stefanpoensgen commented 4 years ago

Yes this is a legacy system plugin, but SwagImportExport is also legacy afaik

shyim commented 4 years ago

So you have to revert the "extra" part back to

 "extra": {
        "installer-paths": {
            "Plugins/Local/Backend/{$name}/": [
                "type:shopware-backend-plugin"
            ],
            "Plugins/Local/Core/{$name}/": [
                "type:shopware-core-plugin"
            ],
            "Plugins/Local/Frontend/{$name}/": [
                "type:shopware-frontend-plugin"
            ]
        }
    },

Without ${name} we have the problem that composer cleared the folder on each installation. So only one could be installed per namespace.

With the associated commit the miss structured zip files will be fixed. So composer places the plugins in right folder.

Reinstalling the plugin now should fix it. I did executed following commands and it looks okay for me

composer req store.shopware.com/swagimportexport
composer req store.shopware.com/hbdevrechtstexte 
❯ ls Plugins/Community/Backend/
  HbdevRechtstexte    SwagImportExport

If its still not working, try to remove composer.lock and clear the composer cache