search

FriendsOfShopware / shopware-cli

CLI for Shopware Account and Shopware 6
MIT License
81 stars 31 forks source link

ESBuild Assets for shopware 6.6 wrong directory #341

Closed tinect closed 4 months ago

tinect commented 4 months ago

PHP Version

No response

Shopware Version

No response

Plugin Version

No response

Actual behaviour

The generated storefront files are placed in storefront/js, but it should be within a subfolder of the technical-name

Expected behaviour

es_build works correct for shopware 6.6

Steps to Reproduce?

build a plugin with storefront js for shopware 6.6

shyim commented 4 months ago

This has nothing to do with shopware-cli. The plugin https://github.com/FriendsOfShopware/FroshLazySizes/ says it supports 6.5 and 6.6. The folder change is not forward compatible with 6.5

You cannot provide in one plugin JS files for 6.5 and 6.6. shopware-cli uses always the lowest shopware version in the range, therefore there is no folder. When you enforce it with custom constraint you will fall into other problems.

Build with 6.5:

When you build using 6.5, the 6.6 users won't have the JS files

Build with 6.6:

When you build with 6.6, it will work in 6.5 and 6.6. BUT as people run build-storefront.sh on 6.5 in their deployment and Shopware, you will end into TWO JS files. TLDR just release two versions for 6.5 and 6.6