search

FriendsOfShopware / shopware-cli

CLI for Shopware Account and Shopware 6
MIT License
81 stars 31 forks source link

Files without extension are not excluded in the 'extension zip' command #370

Closed wannevancamp closed 2 months ago

wannevancamp commented 2 months ago

PHP Version

No response

Shopware Version

No response

Plugin Version

No response

Actual behaviour

shopware-extension.yml

build:
    zip:
        pack:
          excludes:
            paths:
              - .editorconfig
              - .php-cs-fixer.php

When the .editorconfig is available in the extension this file will not be ignored.

Expected behaviour

.editorconfig should be excluded from the zip with it's configured in the exclude list.

Steps to Reproduce?

  1. Add .editorconfig to the extension root
  2. Add .editorconfig to the zip exclude list in the shopware-extension.yaml
  3. Run shopware-cli extension zip .
  4. File still exists in the zip
shyim commented 2 months ago

.editorconfig is by default already excluded and it was removed 🤔

can you provide a repo to reproduce

wannevancamp commented 2 months ago

I'm sorry this was an issue from my side. Can be closed :)