search

FriendsOfSulu / SuluImportExportBundle

Simple Import/Export Bundle for Sulu 2 CMS
MIT License
13 stars 6 forks source link

Reuse doctrine's connection params #6

Closed stollr closed 1 year ago

stollr commented 2 years ago

Currently the user of this bundle has to config the database connection params additionally to the doctrine connection if the DATABASE_URL is used instead of the specific params.

This change adds an auto detection of the connection params used for doctrine. In the case the sulu database differs from the default connection the correct one can be specified in the bundle's config. The readme is updated, too, to reflect this change.

If you like this PR I'd be happy if you labeled it with hacktoberfest-accepted. Thanks in advance.

stollr commented 2 years ago

This PR breaks backward-compatibility in case the database that should be exported/imported differs from doctrine's default connection. So it would make sense if this could be merged into a new "2.x" branch.

stollr commented 1 year ago

@TheCadien is it possible to review and merge this PR?

TheCadien commented 1 year ago

Hey @naitsirch ,I have just given the topic to @dbrumann. He has more expertise in the topic and will do a review soon :) Thanks for the contribution !

TheCadien commented 1 year ago

Then let's just merge it :) Thanks for the great contribution @naitsirch

stollr commented 1 year ago

You're welcome. Thanks for merging and releasing ;-)