search

FriendsOfSylius / AwesomeSylius

Welcome to the SyliusGoose, which is the place you will find more information about Sylius related things.
110 stars 20 forks source link

Porting old bundles from Sylius to the new plugin structure #3

Open gabiudrescu opened 6 years ago

gabiudrescu commented 6 years ago

As far as I know, the original idea of FOSYL was to be a place where the community supports various bundles that were removed from Core.

Some of them being:

Those repos are stale and are not plug and play for the latest Sylius versions, one big reason being they still rely on old components that are incompatible with Sylius dev-master.

I would like to ask the people involved in FOSYL what's their plan with these bundles and if they are willing to convert them to plugins?

Also, I would like to propose two more similar bundles, as per various discussion over Sylius Slack that pointed them as useful. I share those opinion too:

bitbager commented 6 years ago

@adamelso, do you mind if we move the now to your private repositories and once they are finished we mention it in the https://github.com/friendsofsylius/SyliusGoose? 🙂

adamelso commented 6 years ago

@bitbager Some of those are listed on Packagist - I'll check if they have not been installed recently in which case I can make them private, failing that tell Packagist to find them on my personal Github.

@gabiudrescu Archetype and Report are actively being rewritten at the moment - I have even created documentation for both, with information on how to migrate. Regarding them going stale, unfortunately a combination of the Sylius versioning, BC breaks between 0.19 and 1.0, all its Composer dependencies, multiple major PHP versions, and major Symfony versions had made it nearly impossible to provide a smooth transition where one size fits all, hence the delay in getting them updated and rewriting was the only option. Most projects which had previously benefited from these packages have since decided to fork it themselves.

As a result the corresponding ArchetypeBundle and ReportBundle packages themselves will be deprecated since the Symfony bundle and Sylius plugin would be provided by the core package - this will also make it much easier to maintain.

bitbager commented 6 years ago

@adamelso, how things are going?

I think that these plugins would also be categorized as the one from #6, at least for now.

bitbager commented 6 years ago

@adamelso, pinging you again 😄

TomasVotruba commented 6 years ago

What about using @RectorPHP? :)

gabiudrescu commented 6 years ago

well, from what I know, the problem does not necessarily stands in changed namespaces or signature changes, but in different logic and approaches for various stuff.

for example, in 0.xx the Grid Bundle was not that evolved, while in 1.x is heavily used (hope I don't make a mistake).

same for state machines that were not a thing back then.

TomasVotruba commented 6 years ago

different logic and approaches for various stuff.

If you can write that down in before/after, it can be automated.