Closed gabiudrescu closed 6 years ago
from what I can see, the plugin is not final, but maybe @lsmith77 or @solutionDrive-Alt can help us whenever they manage to release it in a functional state - at least Proof of Concept.
basically we want to wrap up the two open PRs (CSV header validation and making the importers more generic), then we should convert it into a plugin and then its "ready" to be listed I would say, though in that case still very basic and incomplete.
cc @Zales0123
well... it's a good starting point. I'm sure people will find it useful whenever they start doing research on the matter.
anyway, keep up the good work!
long term vision for this:
We will need to define what requirements the plugin needs to meet in order to be listed as a ready one. For now, the key things are its stability and documentation. From my point of view, the plugin without the documentation is useless. I also think that we need to require it to be tested due to respect to the Sylius BDD culture.
For now, I think that we can open a PR with a new section for WIP plugins in the README and this is the place packages like this should appear in 🙂
@bitbager Documentation is a good point. Is there any guideline what exactly should be documented and to what extent? Should the documentation be more technical or more from user-perspective?
@solutionDrive-Alt, for now, there's no documentation guideline for plugins, but from my experience, the best way to write it is to keep in mind that a developer who will use it has no idea about its core code and he should not care about it. The key thing is also that for now, as Sylius is a framework, not a platform, the plugins are being installed by developers only. You can take a look at BitBag's README files and follow its standard, for example - https://github.com/bitbag-commerce/CmsPlugin/blob/master/README.md.
BTW pushed some code to https://github.com/solutionDrive/SyliusImportExportPlugin
Added the plugin to WIP section 🙂
code is now at https://github.com/friendsofsylius/SyliusImportExportPlugin
https://github.com/solutionDrive/SyliusImportExport