Update bundle for Sylius 1.9 / Symfony 4.4+||5.2+

[Gogopex]

Q	A
Bug fix?	yes
New feature?	no
BC breaks?	no
Fixed tickets	#241, update to Sylius 1.9

I was met with quite a few errors trying to install this plugin on a brand new Sylius 1.9 webapp. I decided to take some time to fix these, in case you guys want to update this bundle for Symfony 1.9

This PR includes a bunch of updates to a few files:

• a bump to the symfonystopwatch version, allowing the bundle to install succesfully after being composer require'd
• an update to src/DependencyInjection/Configuration.php which ensures that it both works on Symf 5.2, but also maintains BC with 4.1 and older
• ~replaced the ObjectMapper typings with EntityManagerInterface~
• added : inttyping and return 0; to the execute() of all commands (required by Symf 4.4+. I did not use return Command::Success to maximize BC.)
• updated factory declaration of sylius.class_metadata.product_image in services.yml to symf4.4+ format

With just these changes, the bundle installs and all features are working fine. 👍

---

Note: the builds fail because they are using the old dependencies:

DEPENDENCY_VERSIONS="sylius/sylius:1.6.* symfony/symfony:4.2.*"

They should pass once the depency versions are "sylius/sylius:1.9.* symfony/symfony:5.2.*" 👍

[lsmith77]

thank you!

do you also have time to look into the travis setup?

[Gogopex]

thank you!

do you also have time to look into the travis setup?

No problem 👍 I can take a look at the travis setup too, I will update this PR once it's done !

[lsmith77]

BTW most OSS projects have migrated to GithubActions due to Travis slowness. but then again maybe due to everyone having moved Travis is now acceptable in speed.

[Gogopex]

Ok, this first attempt with Travis did not go too well. I'm not super familiar with it but I'll attempt to run the pipeline locally if possible to tinker with it till it runs. 👍

[lsmith77]

I could imagine using composer 2 could solve the memory issue

[Gogopex]

I made some progress on having a passing travis job 🙏

However, the builds are still failing. There is something obvious I must be missing.

Locally I've had no issues with the composer update and everything is working fine, but the Travis job keeps failing on different dependencies mismatches. Here's what I run locally to simulate the job's steps:

composer require "sylius/sylius:1.9.*" --no-update
composer config extra.symfony.require "^5.2"
composer update --prefer-dist

And it goes through without hiccups. Not the case in the Travis job though. ☹️

So I'll be using my fork for now, but I'll come back to this Travis job during the week. If anyone wants to give it a go, feel free !

[Gogopex]

Thank you, @oallain ! I decided to give up on fighting with Travis and started exactly what you are suggesting this morning: https://github.com/MyLittleParis/SyliusImportExportPlugin/pull/6/files

Work got in the way but once I get the github action working on the fork, I will include it in this PR !

I do have one question: what do you think about dropping the support for Sylius <1.7 in order to reduce the number of builds that would run?

Edit: github actions are currently down..! https://www.githubstatus.com/

[oallain]

Thank you, @oallain ! I decided to give up on fighting with Travis and started exactly what you are suggesting this morning: https://github.com/MyLittleParis/SyliusImportExportPlugin/pull/6/files

Work got in the way but once I get the github action working on the fork, I will include it in this PR !

So cool 😎

I do have one question: what do you think about dropping the support for Sylius <1.7 in order to reduce the number of builds that would run?

Yes, to drop Sylius 1.7 and less. But keep 1.8 version.

Edit: github actions are currently down..! https://www.githubstatus.com/

🤕

[lsmith77]

agreed for the bump to 1.8 .. and oh the irony of life with GA being down.

but super appreciative of your commitment and work here @Gogopex

[Gogopex]

Hi guys ! I've finally gotten around to finishing this up, here's what's new:

• I've based most of build pipeline on SyliusSkeletonPlugin's as per @oallain suggestion
• I had to update the tests/Application folder. Again, I inspired myself entirely on SyliusSkeletonPlugin
• There are some version changes in the composer.json, which I also took from SyliusSkeletonPlugin

The pipeline is now fully working; however it now crashes on the Phpstan's step, which doesn't seem to have anything to do with this PR 👍

@oallain @lsmith77 see https://github.com/FriendsOfSylius/SyliusImportExportPlugin/actions/runs/683847071 for where it fails

There is two solutions ahead imo:

• Someone fixes all of these PHPStan issues
• We simply disable/comment/remove the PHPStan step

I'm not sure I can fix all of these issues this week, but I might be able to in the next 10 days, if you guys are too busy. 👍

[lsmith77]

I think we should disable PHPStan in this PR and then have a follow up PR addressing this topic. This PR and you have been burdened so much already without a merge.

Will do a deeper review tomorrow.

[Gogopex]

Hello,

I've taken into account @mbabker's suggestion, thanks 👍

Turns out I also had to comment out PHPSpec (link to example failed build) along with Behat (link to example failed build) for now, otherwise the builds would not pass (the equivalent builds were failing on Jenkins before this PR 😦).

I agree a second PR to fix PHPStan and PHPSpec would be great, along with a PR for the Behat tests! Then everything would be all tidied up!

[lsmith77]

amazing work!

I have created follow up tickets for PHPStan and PHPSpec