search

FriendsOfSymfony / FOSCKEditorBundle

Provides a CKEditor integration for your Symfony project.
Other
519 stars 83 forks source link

Indicate trailing slashes in plugin directory config #129

Closed foucdeg closed 6 years ago

foucdeg commented 6 years ago

Relates to issue https://github.com/FriendsOfSymfony/FOSCKEditorBundle/issues/128. In Symfony directories are usually specified without trailing slashes, so I feel it might be important to insist on the trailing slash here.

Q A
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Fixed tickets Issue #128
License MIT
kunicmarko20 commented 6 years ago

Can you please rebase this to 1.x branch as that is the current stable, we merge later to master

foucdeg commented 6 years ago

@kunicmarko20 not sure how to do that, I used Github's online file editor. I'll try another PR from the 1.x version of the file.

kunicmarko20 commented 6 years ago

Tried changing from github but it just messed things up

foucdeg commented 6 years ago

@kunicmarko20 don't worry, I'll open another one from the 1.x version of the file

foucdeg commented 6 years ago

See #130