search

FriendsOfSymfony / FOSCKEditorBundle

Provides a CKEditor integration for your Symfony project.
Other
519 stars 83 forks source link

Replace ResourceCompilerPass with Flex recipe #136

Closed kunicmarko20 closed 6 years ago

kunicmarko20 commented 6 years ago

https://github.com/FriendsOfSymfony/FOSCKEditorBundle/blob/43e0ec349cd809959f490d23e3e37b87c1314191/src/DependencyInjection/Compiler/ResourceCompilerPass.php#L28-L35

Twig is now mandatory so that if makes no sense. I do not like modifing parameters like this, before we didn't have recipes and this would remove 1 extra step, but now there is no need for this.

kunicmarko20 commented 6 years ago

@ElectricMaxxx wdyt?

ElectricMaxxx commented 6 years ago

Let us do it in a reciepe.