Closed jmsche closed 5 years ago
Had to do the same thing, thank you! Can you maybe check the build errors?
I'm no Travis expert, but I tried to fix the DI component to version 4.2 for the phpstan check - seems it breaks memory limit (which is set to 1.5GB).
Should I increase composer's memory limit for this build? Do you think this issue is "normal"?
Not a normal issue, will check it out tonight
Just pushed a commit increasing the memory limit of composer - for this check - reveals the sensio/distribution-bundle
dependency can't be installed as it requires DI < 4.
Also, an other failing test, but I think it is unrelated to what I did.
Any idea how I can fix this dependency issue?
Accidentally closed, didn't have time to check this and now I am afk for a few days. Do we event need distribution bundle?
About test, took a quick look and it seems that new version of phpunit has a different signature which is a BC break, not sure tho
Do we event need distribution bundle?
For Symfony < 4 I guess. It shouldn't install if Flex is already there.
Do we use it in code? If no, drop it, sf should install it as its dependency
Update symfony phpunit bridge to 4.1 that should solve it IIRC.
Also, do we still need memory limit?
I removed composer memory_limit env var as it's not required anymore - needed it to get the error message from composer.
Well, it only gets worse :p I changed the min requirement of phpunit bridge to ^4.1, now two tests fail.
Try adding - SYMFONY_PHPUNIT_VERSION="6.5"
to the test block that's failing
Green :tada: now to address suggestions by @angelsk
Should be good now, thank you @jmsche and @angelsk!
Hi, this PR fixes a small deprecation introduced in Symfony 4.2; the fix includes a BC layer for older versions.