search

FriendsOfSymfony / FOSCKEditorBundle

Provides a CKEditor integration for your Symfony project.
Other
518 stars 83 forks source link

Lots of deprecations #190

Closed lukepass closed 5 years ago

lukepass commented 5 years ago

Environment

Website built with Symfony 3.4.

Symfony packages

$ composer show --latest 'symfony/*'
symfony/http-client           v4.3.2  v4.3.2  Symfony HttpClient component
symfony/http-client-contracts v1.1.5  v1.1.5  Generic abstractions related to HTTP clients
symfony/mime                  v4.3.2  v4.3.2  A library to manipulate MIME messages
symfony/monolog-bundle        v3.4.0  v3.4.0  Symfony MonologBundle
symfony/phpunit-bridge        v4.3.2  v4.3.2  Symfony PHPUnit Bridge
symfony/polyfill-apcu         v1.11.0 v1.11.0 Symfony polyfill backporting apcu_* functions to lower PHP versions
symfony/polyfill-ctype        v1.11.0 v1.11.0 Symfony polyfill for ctype functions
symfony/polyfill-intl-icu     v1.11.0 v1.11.0 Symfony polyfill for intl's ICU-related data and classes
symfony/polyfill-intl-idn     v1.11.0 v1.11.0 Symfony polyfill for intl's idn_to_ascii and idn_to_utf8 functions
symfony/polyfill-mbstring     v1.11.0 v1.11.0 Symfony polyfill for the Mbstring extension
symfony/polyfill-php56        v1.11.0 v1.11.0 Symfony polyfill backporting some PHP 5.6+ features to lower PHP versions
symfony/polyfill-php70        v1.11.0 v1.11.0 Symfony polyfill backporting some PHP 7.0+ features to lower PHP versions
symfony/polyfill-php72        v1.11.0 v1.11.0 Symfony polyfill backporting some PHP 7.2+ features to lower PHP versions
symfony/polyfill-php73        v1.11.0 v1.11.0 Symfony polyfill backporting some PHP 7.3+ features to lower PHP versions
symfony/polyfill-util         v1.11.0 v1.11.0 Symfony utilities for portability of PHP codes
symfony/security-acl          v3.0.2  v3.0.2  Symfony Security Component - ACL (Access Control List)
symfony/swiftmailer-bundle    v2.6.7  v3.2.8  Symfony SwiftmailerBundle
symfony/symfony               v3.4.29 v4.3.2  The Symfony PHP framework

Subject

Hello, there are a lot of deprecations when using this bundle:

  1x: The FOS\CKEditorBundle\ModelStylesSetManager is deprecated since 1.x and will be removed with the 2.0 release.
    1x in AdminTest::routeProvider from Tests\AppBundle\Admin

  1x: The FOS\CKEditorBundle\ModelToolbarManagerInterface is deprecated since 1.x and will be removed with the 2.0 release.
    1x in AdminTest::routeProvider from Tests\AppBundle\Admin

  1x: The FOS\CKEditorBundle\ModelToolbarManager is deprecated since 1.x and will be removed with the 2.0 release.
    1x in AdminTest::routeProvider from Tests\AppBundle\Admin

  1x: The FOS\CKEditorBundle\ModelTemplateManagerInterface is deprecated since 1.x and will be removed with the 2.0 release.
    1x in AdminTest::routeProvider from Tests\AppBundle\Admin

  1x: The FOS\CKEditorBundle\ModelTemplateManager is deprecated since 1.x and will be removed with the 2.0 release.
    1x in AdminTest::routeProvider from Tests\AppBundle\Admin

  1x: The FOS\CKEditorBundle\ModelStylesSetManagerInterface is deprecated since 1.x and will be removed with the 2.0 release.
    1x in AdminTest::routeProvider from Tests\AppBundle\Admin

  1x: The FOS\CKEditorBundle\DependencyInjection\CompilerResourceCompilerPass is deprecated since 1.x and will be removed with the 2.0 release.
    1x in AdminTest::routeProvider from Tests\AppBundle\Admin

  1x: The FOS\CKEditorBundle\DependencyInjection\CompilerTemplatingCompilerPass is deprecated since 1.x and will be removed with the 2.0 release.
    1x in AdminTest::routeProvider from Tests\AppBundle\Admin

  1x: The FOS\CKEditorBundle\ModelPluginManager is deprecated since 1.x and will be removed with the 2.0 release.
    1x in AdminTest::routeProvider from Tests\AppBundle\Admin

  1x: The FOS\CKEditorBundle\ModelConfigManagerInterface is deprecated since 1.x and will be removed with the 2.0 release.
    1x in AdminTest::routeProvider from Tests\AppBundle\Admin

  1x: The FOS\CKEditorBundle\ModelConfigManager is deprecated since 1.x and will be removed with the 2.0 release.
    1x in AdminTest::routeProvider from Tests\AppBundle\Admin

  1x: The FOS\CKEditorBundle\ModelPluginManagerInterface is deprecated since 1.x and will be removed with the 2.0 release.
    1x in AdminTest::routeProvider from Tests\AppBundle\Admin

How can I get rid of them? I can make a pull request if you tell me which replacement should I use.

Thanks

kunicmarko20 commented 5 years ago

You are using old version of ckeditor, please update to 2+.

lukepass commented 5 years ago

Unfortunately I don't think it's possible for me to upgrade because the sonata-project/formatter-bundle still requires the v1 version:

composer require friendsofsymfony/ckeditor-bundle 
    Finished: success: 10, skipped: 0, failure: 0, total: 10
Using version ^2.1 for friendsofsymfony/ckeditor-bundle
./composer.json has been updated
Loading composer repositories with package information
Updating dependencies (including require-dev)
Your requirements could not be resolved to an installable set of packages.

  Problem 1
    - sonata-project/formatter-bundle 4.1.3 requires friendsofsymfony/ckeditor-bundle ^1.0 -> satisfiable by friendsofsymfony/ckeditor-bundle[1.0.0, 1.0.0-RC1, 1.0.0-RC2, 1.0.0-RC3, 1.1.0, 1.2.0, 1.x-dev] but these conflict with your requirements or minimum-stability.
    - sonata-project/formatter-bundle 4.1.3 requires friendsofsymfony/ckeditor-bundle ^1.0 -> satisfiable by friendsofsymfony/ckeditor-bundle[1.0.0, 1.0.0-RC1, 1.0.0-RC2, 1.0.0-RC3, 1.1.0, 1.2.0, 1.x-dev] but these conflict with your requirements or minimum-stability.
    - sonata-project/formatter-bundle 4.1.3 requires friendsofsymfony/ckeditor-bundle ^1.0 -> satisfiable by friendsofsymfony/ckeditor-bundle[1.0.0, 1.0.0-RC1, 1.0.0-RC2, 1.0.0-RC3, 1.1.0, 1.2.0, 1.x-dev] but these conflict with your requirements or minimum-stability.
    - Installation request for sonata-project/formatter-bundle (locked at 4.1.3, required as ^4.1) -> satisfiable by sonata-project/formatter-bundle[4.1.3].

Installation failed, reverting ./composer.json to its original content.
jessequinn commented 4 years ago

composer require friendsofsymfony/ckeditor-bundle:1.2.0

will resolve your issue. from what i know 2.1 is not supported!