search

FriendsOfSymfony / FOSCKEditorBundle

Provides a CKEditor integration for your Symfony project.
Other
518 stars 83 forks source link

Symfony 5 support #201

Closed endroid closed 4 years ago

endroid commented 4 years ago
Q A
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
License MIT
michaljusiega commented 4 years ago

Please bump the version to use with SF 5.0...

mthiebaut commented 4 years ago

Hello,

I'm interessed about this modification, can you merge this request?

lsmith77 commented 4 years ago

please someone test 2.x to confirm if its working in a real world app .. and then I will tag a release

nacholibre commented 4 years ago

Just testing with symfony 5 using https://github.com/FriendsOfSymfony/FOSCKEditorBundle/commit/7e1cfe2a83faba0be02661d44289d35e940bb5ea, ckeditor:install fails, but it works using the webpack!


user ✗ php bin/console ckeditor:install
----------------------
| CKEditor Installer |
----------------------

 // Downloading CKEditor ZIP archive from "https://github.com/ckeditor/ckeditor-releases/archive/full/latest.zip"

 1744510/1744510 [============================] 100%

 // Extracting CKEditor ZIP archive to "/Users/nacholibre/Development/nachoblog/vendor/friendsofsymfony/ckeditor-bundle/src/Resources/public"

In CKEditorInstaller.php line 256:

  Attempted to load class "ZipArchive" from the global namespace.
  Did you forget a "use" statement?

ckeditor:install [--release [RELEASE]] [--custom-build-id [CUSTOM-BUILD-ID]] [--tag [TAG]] [--clear [CLEAR]] [--exclude [EXCLUDE]] [-nobar|--no-progress-bar] [-h|--help] [-q|--quiet] [-v|vv|vvv|--verbose] [-V|--version] [--ansi] [--no-ansi] [-n|--no-interaction] [-e|--env ENV] [--no-debug] [--] <command> [<path>]```
lsmith77 commented 4 years ago

hmm that issue would be caused if you don't have ext-zip installed https://www.php.net/manual/en/book.zip.php

but this dependency is listed in the composer.json: https://github.com/FriendsOfSymfony/FOSCKEditorBundle/blob/2.x/composer.json#L21

nacholibre commented 4 years ago

@lsmith77 ops, you are right, I don't have ext-zip, but I ran composer install with different php binary which had ext-zip installed, everything is fine then!

lsmith77 commented 4 years ago

ah cool .. so you can confirm that master is working fine with Symfony 5 ?

nacholibre commented 4 years ago

Yes, it's working.

lsmith77 commented 4 years ago

https://github.com/FriendsOfSymfony/FOSCKEditorBundle/releases/tag/2.2.0