search

FriendsOfSymfony / FOSCKEditorBundle

Provides a CKEditor integration for your Symfony project.
Other
522 stars 84 forks source link

License is not understood by BlackDuck - Synopsis #221

Closed llupa closed 3 years ago

llupa commented 4 years ago

Feature Request

Update current LICENSE file content to be picked up by BlackDuck.

lsmith77 commented 3 years ago

please submit a PR

llupa commented 3 years ago

I have submitted #226 on the 1.X branch, I was wondering if I should submit a second one on 2.X or would it be easier to cherry pick the commit? Let me know!

lsmith77 commented 3 years ago

are you still using the 1.x branch?

since we are short on resources I don’t think we want to keep maintaining that branch

On Sat, 26 Dec 2020 at 12:15, llupa notifications@github.com wrote:

I have submitted #226 https://github.com/FriendsOfSymfony/FOSCKEditorBundle/pull/226 on the 1.X branch, I was wondering if I should submit a second one on 2.X or would it be easier to cherry pick the commit. Let me know!

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/FriendsOfSymfony/FOSCKEditorBundle/issues/221#issuecomment-751345663, or unsubscribe https://github.com/notifications/unsubscribe-auth/AACJJ527RTEMTFDO6WYALG3SWXAUZANCNFSM4TMOZYEA .

-- regards, Lukas

llupa commented 3 years ago

Hello Lukas,

I expected this reaction from you. Unfortunately we have a really large project and upgrading to Symfony 4.4 from 3.4 is taking a lot of time for us. Our plan is to have it done by June 2021. (started Sep. 2020)

I completely understand your sentiment here and I was hoping that given the nature of the PR file changes you could accept it for both 1.X and 2.X? It would help us a lot from having to fork it til we can move to 2.X!

Can we bribe you with McMeal 😄 ?

In any case, let me know and I will change the PR to your liking.

Kind regards, Llupa

lsmith77 commented 3 years ago

if it helps then I am happy to consider making a release

On Sat, 26 Dec 2020 at 13:34, llupa notifications@github.com wrote:

Hello Lukas,

I expected this reaction from you. Unfortunately we have a really large project and upgrading to Symfony 4.4 from 3.4 is taking a lot of time for us. Our plan is to have it done by June 2021. (started Sep. 2020)

I completely understand your sentiment here and I was hoping that given the nature of the PR file changes you could accept it for both 1.X and 2.X? It would help us a lot from having to fork it til we can move to 2.X!

Can we bribe you with McMeal 😄 ?

In any case, let me know and I will change the PR to your liking.

Kind regards, Llupa

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/FriendsOfSymfony/FOSCKEditorBundle/issues/221#issuecomment-751351844, or unsubscribe https://github.com/notifications/unsubscribe-auth/AACJJ56QA3G4E3JY6HO3LRTSWXJ7HANCNFSM4TMOZYEA .

-- regards, Lukas

llupa commented 3 years ago

It definitely helps since legal is constantly asking us to drop the dependency due to "risky" licensing, even if we have to explain each month that the license is fine, it is just not picked up by BlackDuck.

I know it sounds like #FirstWorldProblems but in corporation life these matter. Btw, we would still have this issue even if we upgraded to 2.X, a LICENSE header edit will be more than welcomed by anyone who uses such tools.

Best, Llupa

lsmith77 commented 3 years ago

I just released 1.2.1

On Sat, 26 Dec 2020 at 13:42, llupa notifications@github.com wrote:

It definitely helps since legal is constantly asking us to drop the dependency due to "risky" licensing, even if we have to explain each month that the license is fine, it is just not picked up by BlackDuck.

I know it sounds like #FirstWorldProblems but in corporation life these matter. Btw, we would still have this issue even if we upgraded to 2.X, a LICENSE header edit will be more than welcomed by anyone who uses such tools.

Best, Llupa

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/FriendsOfSymfony/FOSCKEditorBundle/issues/221#issuecomment-751352415, or unsubscribe https://github.com/notifications/unsubscribe-auth/AACJJ557QD7NLOVA5GHV3WDSWXK5DANCNFSM4TMOZYEA .

-- regards, Lukas