search

FriendsOfSymfony / FOSCKEditorBundle

Provides a CKEditor integration for your Symfony project.
Other
516 stars 83 forks source link

Drop Symfony 3.4 + Migrate Travis to github actions + Add php 8 support #223

Closed VincentLanglet closed 3 years ago

VincentLanglet commented 3 years ago

Close https://github.com/FriendsOfSymfony/FOSCKEditorBundle/issues/222

VincentLanglet commented 3 years ago

I started working on https://github.com/FriendsOfSymfony/FOSCKEditorBundle/issues/222 @jmsche but the github actions is not triggered. Maybe you know why ?

Is there something to configure on the repository for github actions to work ? @lsmith77

jmsche commented 3 years ago

As it is not merged in this repository, actions are run in your own repo only, see https://github.com/VincentLanglet/FOSCKEditorBundle/actions

VincentLanglet commented 3 years ago

As it is not merged in this repository, actions are run in your own repo only, see https://github.com/VincentLanglet/FOSCKEditorBundle/actions

Thanks

jmsche commented 3 years ago

You may want to change the PR's title as it also drop 3.4 & add PHP 8 support :)

VincentLanglet commented 3 years ago

@kunicmarko20 @lsmith77 This seems ready to be merged to me :)

Tests are green: https://github.com/VincentLanglet/FOSCKEditorBundle/actions/runs/424310014

kunicmarko20 commented 3 years ago

Hey @VincentLanglet, sorry but I am not a maintainer of this package anymore, hopefully, @lsmith77 or @ElectricMaxxx could help with it.

VincentLanglet commented 3 years ago

Hey @VincentLanglet, sorry but I am not a maintainer of this package anymore, hopefully, @lsmith77 or @ElectricMaxxx could help with it.

No problem, I had just trouble to find the maintainer of this package ; didn't find the information on the Readme.

lsmith77 commented 3 years ago

honestly this package might not have an active maintainer right now.

but as always, I am willing to do the final review if people like you put int the effort. in that spirit we can also discuss potentially you becoming the official maintainer.

I added a small question but otherwise it looks good indeed!

VincentLanglet commented 3 years ago

honestly this package might not have an active maintainer right now.

It seems indeed.

but as always, I am willing to do the final review if people like you put int the effort.

Thanks

in that spirit we can also discuss potentially you becoming the official maintainer.

I don't know much about this package, maybe with a "look for maintainer" issue, there will be better candidate. I currently trying to add the php 8 compatibility on a multiple bundles. But I'm not against helping more.

lsmith77 commented 3 years ago

thank you!

I guess only after merging it will be possible for you to confirm if the setup works properly.

lsmith77 commented 3 years ago

so are you able to confirm it works now? also I just noticed that we then also need to update the badges in the README to no longer point to travis-ci https://github.com/FriendsOfSymfony/FOSCKEditorBundle/blob/2.x/README.md

lsmith77 commented 3 years ago

see also #224

VincentLanglet commented 3 years ago

so are you able to confirm it works now?

My project have other dependencies which are not compatible with PHP8, so I currently cannot test it. I would recommend to create a release and see what happen.

also I just noticed that we then also need to update the badges in the README to no longer point to travis-ci https://github.com/FriendsOfSymfony/FOSCKEditorBundle/blob/2.x/README.md

Fixed in https://github.com/FriendsOfSymfony/FOSCKEditorBundle/pull/225

jmsche commented 3 years ago

@lsmith77 I just tested against a new sample Symfony app, using Symfony 5.2.1 & PHP 8.0.0 & it works :)