FriendsOfSymfony / FOSCKEditorBundle

Provides a CKEditor integration for your Symfony project.
Other
519 stars 83 forks source link

Add support for Symfony 6.0 #239

Closed artoroz closed 2 years ago

artoroz commented 2 years ago
Q A
Bug fix? no
New feature? no
BC breaks? no
Deprecations? /no
License MIT
jmsche commented 2 years ago

Maybe it's time.to drop unsupported versions of PHP?

artoroz commented 2 years ago

Maybe it's time.to drop unsupported versions of PHP?

That would solve the problem of compatibility with phpunit 7 Also added check with php 8.1

artoroz commented 2 years ago

Any feedback on this?

FluffyDiscord commented 2 years ago

please merge it asap

0x6d6c commented 2 years ago

Also closes #240.

paulalbertdev commented 2 years ago

I'd be interested to be able to use FOSCKEditorBundle with Symfony 6 too ;)

VincentLanglet commented 2 years ago

Hi @lsmith77, is something needed for this to be merge ? :)

lsmith77 commented 2 years ago

Hi @lsmith77, is something needed for this to be merge ? :)

a maintainer :-/

I am not using Symfony for a while now and too busy with my new role as co-founder in a startup.

I fear @ElectricMaxxx also is no longer active on this bundle.

lsmith77 commented 2 years ago

changes look safe enough .. so merging but we need to someone take over maintenance and do a release.

w3sami commented 2 years ago

for anyone else finding themselves in here, because you read the last commit promising sf6 support, but then run into Problem 1

when installing via composer, use composer require friendsofsymfony/ckeditor-bundle:"@dev" to get the latest code with out the release :)

ChristianVermeulen commented 2 years ago

when installing via composer, use composer require friendsofsymfony/ckeditor-bundle:"@dev" to get the latest code with out the release :)

Just be aware you are running a development version of the code which might not have been fully tested yet ;-). I prefer to wait for the next release for production environments.

jmsche commented 2 years ago

FYI I've been using artoroz's branch on production for more than a month without any issues.

lsmith77 commented 2 years ago

the situation is that there is currently not really a proper maintainer. so I would ask people to test this release and provide feedback here. if I see enough people confirming that things work fine, I can do a (last) release.

Note the Bundle might become a UX component in the future: https://twitter.com/lsmith/status/1479433042229870599?s=21

artoroz commented 2 years ago

At this moment i am running at 2.x branch without any problems on production

jontjs commented 2 years ago

The 2.x branch is also working for me, with Symfony 6.

lsmith77 commented 2 years ago

ok cool .. sounds good.

will do a release today or tmorrow

lsmith77 commented 2 years ago

https://github.com/FriendsOfSymfony/FOSCKEditorBundle/releases/tag/2.4.0