search

FriendsOfSymfony / FOSCKEditorBundle

Provides a CKEditor integration for your Symfony project.
Other
519 stars 83 forks source link

Add phpunit groups #31

Closed kunicmarko20 closed 6 years ago

kunicmarko20 commented 6 years ago

I suggest we add @group to tests that run install and download stuff, for me at least, build takes so much time locally and I do not want to wait that long to confirm if I broke stuff.

Adding @group installation to:

https://github.com/FriendsOfSymfony/FOSCKEditorBundle/blob/master/Command/CKEditorInstallerCommand.php and https://github.com/FriendsOfSymfony/FOSCKEditorBundle/blob/master/Installer/CKEditorInstaller.php

would allow us to run tests with phpunit --exclude-group installation and build is done in 15 seconds, and then we leave travis to confirm if installation works.

kunicmarko20 commented 6 years ago

Also, maybe we can have just one run that would test this installation, some runs currently hang because of that.

ElectricMaxxx commented 6 years ago

Nice indeed, this would be away to do the download on each test.

ElectricMaxxx commented 6 years ago

we could add the option to PHPUNIT_FLAGS environment when needed, yes makes sense. :-)