Javascript is outdated and needs an overhaul

[nreynis]

The javascript client has several problems and needs a bit of attention:

• Use of deprecated methods which have been removed from jQuery 3 (critical: jQuery 3 has been released 18 months ago! Any new project is likely to use it and will have problem with this bundle.)
• Use of assetic which is deprecated. You should deliver something more webpack friendly as webpack/remix is now the recommanded tool for Symfony
• Global variables. You should use html5 data-attributes instead
• Auto initialisation on parse. You should init on DOMContentReady so that the user is free to put his script where he wants

[nreynis]

Just found #604. Forcing dev stability solve the first issue composer require friendsofsymfony/comment-bundle:^3.0@dev.

I still thinks the other points are valid and should be addressed in some way. But that's more of an opinion, so feel free to close and ignore if you don't agree.

[stof]

for the global variables vs data attributes, a PR adding support for data-attributes would be OK (but not removing support for the global variable, to prevent BC breaks).

Note that I don't know of any FOS member actively using this bundle anymore (I may be wrong about this though), so changes are relying on community contributions.

[yakobe]

@stof could you share what people are using as an alternative? Perhaps it is time to concentrate resources into a better package if available and formally deprecate/abandon this one.

[XWB]

jQuery 3 is supported in master branch. I'll make a new release as soon as the next FOSRestBundle is released.

I agree it would be nice to have HTML 5 data attributes, perhaps someone is willing to create a PR?

I also agree on DOMContentReady. That should be an easy fix.

Regarding the assets, unfortunately I have not yet used Webpack so I have no clue what needs to be changed.