search

FriendsOfSymfony / FOSCommentBundle

Threaded comments for Symfony
http://friendsofsymfony.github.com/
MIT License
462 stars 230 forks source link

Fixing issue #635 #651

Closed emulienfou closed 6 years ago

emulienfou commented 6 years ago

Using format @FOSComment/Thread/ instead of new TemplateReference('FOSCommentBundle', 'Thread', to allow templating override in Symfony 4.

Fixing issue #635

XWB commented 6 years ago

Looks good. Is it compatible with Symfony 2.7 and above?

emulienfou commented 6 years ago

Hi @XWB, according to the Symfony documentation, this notation in compatible with Symfony 2.7.

However, not with 2.0 to 2.6! But checking in the composer.json file, this bundle support Symfony 2.7 and above!

FYI: I only test my fix on SF4!

XWB commented 6 years ago

Alright.

Can you remove the TemplateReference import as well?

emulienfou commented 6 years ago

Whoops, my bad! Done

XWB commented 6 years ago

Thanks. I'll fix Travis at a later date.