search

FriendsOfSymfony / FOSCommentBundle

Threaded comments for Symfony
http://friendsofsymfony.github.com/
MIT License
462 stars 230 forks source link

Reopeninig: Use the correct Symfony Controller class based on Symfony version #681

Closed snebes closed 5 years ago

snebes commented 5 years ago

Ref #671

I hate to have to do this, but at this point in time, Symfony is throwing the deprecation messages without a way ignore them. Even their tests are checking for them. This required a tweak to the travis config.

Also updated 2 interfaces with incorrect docBlocks.

XWB commented 5 years ago

Nice, thanks @snebes :)

onEXHovia commented 5 years ago

@XWB this is a BC break for me on version symfony 4.3

An exception has been thrown during the rendering of a template ("Service "fos_comment.manager.thread" not found: even though it exists in the app's container, the container inside "App\Controller\ThreadController" is a smaller service locator that only knows about the "doctrine", "form.factory", "http_kernel", "parameter_bag", "request_stack", "router", "security.authorization_checker", "security.csrf.token_manager", "security.token_storage", "serializer", "session", "templating" and "twig" services. Try using dependency injection instead.").

AbstractController uses a limited dependencies in container. More information: https://github.com/symfony/symfony-docs/issues/9926#issuecomment-398334268 https://github.com/symfony/symfony-docs/issues/9926#issuecomment-398742127