Do no work using internet explorer

FriendsOfSymfony / FOSFacebookBundle

NOT MAINTAINED - see https://github.com/hwi/HWIOAuthBundle

321 stars 140 forks source link

Do no work using internet explorer #103

Closed babour closed 12 years ago

babour commented 12 years ago

I can't login when I user internet eplorer, an other page opens and is empty.

babour commented 12 years ago

I looked a bit into the code and it seems, it's because of the window.location that doesn't work on internet explorer. Even using the setTimeout trick (check on google) that used to work, it doesn't change anything...

Anyone has solved this issue?

babour commented 12 years ago

You need to use the window.location.href function instead of window.location, and then it works

lsmith77 commented 12 years ago

if you think it can help others, send a PR for an improvement to the README.md

babour commented 12 years ago

How? Can't find how to creqte one (I don't really know github), do I have to fork the repository?

lsmith77 commented 12 years ago

Its even easier .. you can browse to the README.md and "click" edit: https://github.com/FriendsOfSymfony/FOSFacebookBundle/blob/master/README.md

this will help you create a fork and a branch to submit as a PR