FriendsOfSymfony / FOSFacebookBundle

NOT MAINTAINED - see https://github.com/hwi/HWIOAuthBundle
321 stars 140 forks source link

change FacebookSession class variable visibility to protected #167

Closed inoryy closed 12 years ago

inoryy commented 12 years ago

Simple change to allow extension of this class.

Specifically, trying to override constructor method is impossible because of private visibility.

weaverryan commented 12 years ago

This relates to #79 and would allow us to sub-class and not start the session only in the test environment. We've all got this file hot-patched locally when we run our tests, so this should make life easier :).

So, +1 for my end

stof commented 12 years ago

I merged #161 instead as it was sent first with the same change