FriendsOfSymfony / FOSFacebookBundle

NOT MAINTAINED - see https://github.com/hwi/HWIOAuthBundle
322 stars 140 forks source link

facebook sdk version 3.2.0 instead of 3.2.2? #273

Open hosseio opened 11 years ago

hosseio commented 11 years ago

Hi. We are upgrading from symfony 2.0 to symfony 2.1. When using composer to update FOSFacebook we are getting the facebook sdk (base_facebook) version 3.2.0 when with deps under symfony2.0 the version was 3.2.2. With this version of facebook sdk we are having issues with the access token, this code is added in version 3.2.2 in getUserAccessToken function:

    if ($code && $code == $this->getPersistentData('code')) {
      // short-circuit if the code we have is the same as the one presented
      return $this->getPersistentData('access_token');
    }

Are we missing something or the composer file of FOSFacebook should require the last version of the php facebook sdk?

stof commented 11 years ago

The composer requirement in FOSFacebookBundle allows any 3.2 version. So nothing should prevent using 3.2.2 (it is installed by composer on Travis).

Are you defining a requirement on the facebook sdk in your root composer.json too ?

hosseio commented 11 years ago

I am not. In fact I tried to, but don't want to repeat requierements. Why aren't it getting the last version of the sdk? I am going to studied it deeper. If I found any solution I will share it.

Thank you.