search

FriendsOfSymfony / FOSFacebookBundle

NOT MAINTAINED - see https://github.com/hwi/HWIOAuthBundle
322 stars 140 forks source link

@fos_user.user_manager is deprecated #290

Closed pedrotypes closed 10 years ago

stof commented 10 years ago

Given that the class needs to manage users, this change is wrong (you will get fatal errors). It will not be able to create new users if it receives only a UserProvider.

What is deprecated in FOSUserBundle is using the UserManager as a Security UserProvider. The proper fix is to update the example implementation of the FacebookProvider to stop relying on the fact that the user manager was also a user provider and use only the public API of the user manager.

stof commented 10 years ago

On a side note, I recommend you to use https://github.com/hwi/HWIOAuthBundle to provide Facebook login on your site instead of FOSFacebookBundle. The implementation is cleaner and nobody in FOS is actively using this bundle anymore (the Facebook SDK used by this bundle is responsible of lots of issues, and we already had to rewrite half of it to make it use the Symfony sessions properly...)

pedrotypes commented 10 years ago

@stof having further studied this issue, I see you're right. Sorry for jumping the gun on the PR and thanks for the suggestion. Cheers!