FriendsOfSymfony / FOSHttpCacheBundle

Use the FOSHttpCache library in your Symfony projects
http://foshttpcachebundle.readthedocs.io
Other
430 stars 80 forks source link

Fastly support #585

Closed NicoImparfait closed 10 months ago

NicoImparfait commented 2 years ago

Fos Http Cache supports Fastly as a proxy client but it is not configurable in fos http cache bundle.

It would look like:

fos_http_cache:
    proxy_client:
        fastly:
            service_identifier: '<my-app-identifier>',
            authentication_token: > '<user-authentication-token>',
            soft_purge: false
dbu commented 2 years ago

yep, fastly support was added later on, and it seems nobody built the configuration in the bundle yet. do you want to contribute this?

to build it, inspiration can be taken from the existing options like varnish, creating a new configuration section and service files to load in https://github.com/FriendsOfSymfony/FOSHttpCacheBundle/tree/2.x/src/Resources/config

DemigodCode commented 1 year ago

Just created a PR https://github.com/FriendsOfSymfony/FOSHttpCacheBundle/pull/597

DemigodCode commented 10 months ago

@dbu think we can close this issue

dbu commented 10 months ago

oh indeed, thanks!

done in #597