FriendsOfSymfony / FOSHttpCacheBundle

Use the FOSHttpCache library in your Symfony projects
http://foshttpcachebundle.readthedocs.io
Other
430 stars 80 forks source link

Fix compiling container using Secrets #606

Closed DemigodCode closed 10 months ago

DemigodCode commented 10 months ago

If one wants to use secrets as parameters for fastly or cloudflare, the compiling of the container will fail. After compiling the container the termination event will cause this error cause it's not necessary to have the decrypt key available when compiling the container and the service can't be initialized.

This fix creates the services as lazy services which will not make the options necessary on compile time of the container.

DemigodCode commented 10 months ago

@dbu same in 3.x closed 2.x PR, don't know how to rebase it and created this one.

dbu commented 10 months ago

oh sorry. i mixed up FOSHttpCache where i fixed things and FOSHttpCacheBundle :see_no_evil:

i fixed the build in #608 and then merged things up to 3.x - can you please rebase on the 3.x branch?.

DemigodCode commented 10 months ago

Done

dbu commented 10 months ago

thanks a lot! merged in #609