search

FriendsOfSymfony / FOSJsRoutingBundle

A pretty nice way to expose your Symfony routing to client applications.
1.48k stars 261 forks source link

Remove Closure library dependency #256

Open bensampaio opened 8 years ago

bensampaio commented 8 years ago

Hi! Would it be possible to remove the dependency on Closure library and make the JS more modular? ES6/ES2015 already provides all the functionality you are using the Closure library for, but it is the standard so dependencies on external libraries are not necessary.

If that is not as possibility in the near future, is there a way to import your Router as a module instead of adding so many variables to the global scope? Thank you!

willdurand commented 8 years ago

The initial version has been written in plain JS, then we refactored the code with Closure, so rewriting the JS once again should be ok, but I will not do that myself ;-) I don't think there is a huge value in updating the JS, but why not as far as it still passes the test suite.

bensampaio commented 8 years ago

Any idea on when you could give priority to this?

xabbuh commented 8 years ago

@bensampaio As far as I understand @willdurand he is not planing do that himself, but he welcomes you to create a pull request that changes the JavaScript implementation.

bensampaio commented 8 years ago

I created a PR: #257.